Re: [PATCHv2 4/5] Git.pm: add interface for git credential command

2013-02-07 Thread Jeff King
On Thu, Feb 07, 2013 at 03:01:20PM +0100, Michal Nazarewicz wrote: > > There are a few disallowed characters, like "\n" in key or value, and > > "=" in a key. They should never happen unless the caller is buggy, but > > should we check and catch them here? > > I left it as is for now since it

Re: [PATCHv2 4/5] Git.pm: add interface for git credential command

2013-02-07 Thread Michal Nazarewicz
On Fri, Feb 08 2013, Junio C Hamano wrote: > I'd actually be more worried about the error checking issue > Peff raised during his review. I have a feeling that "when in doubt, > do not cause harm" is a more prudent way to go than "I do not know, > so I'll let anything pass". I can implement whate

Re: [PATCHv2 4/5] Git.pm: add interface for git credential command

2013-02-07 Thread Junio C Hamano
Matthieu Moy writes: > Michal Nazarewicz writes: > >> From: Michal Nazarewicz >> >> Add a credential() function which is an interface to the git >> credential command. The code is heavily based on credential_* >> functions in . > > I'm no perl expert, so I cannot comment much on style (there a

Re: [PATCHv2 4/5] Git.pm: add interface for git credential command

2013-02-07 Thread Matthieu Moy
Michal Nazarewicz writes: > From: Michal Nazarewicz > > Add a credential() function which is an interface to the git > credential command. The code is heavily based on credential_* > functions in . I'm no perl expert, so I cannot comment much on style (there are many small changes compared to