Stefan Beller writes:
> I am not sure if I see the upside on wrapping a single value except for
> its future proofness,
I do not see anything other than future-proofing, either. If we
need to touch all the code that uses the attributes to update the
API, I'd prefer to avoid having to do that ag
On Tue, Oct 18, 2016 at 5:06 PM, Junio C Hamano wrote:
> On Tue, Oct 18, 2016 at 4:52 PM, Stefan Beller wrote:
>>
>> >
>> > By the way, I do see a merit on the "check" side (tl;dr: but I do
>> > not think "result" needs it, hence I do not see the need for the
>> > "ugly" variants).
>>
>> So we'd
On Tue, Oct 18, 2016 at 4:52 PM, Stefan Beller wrote:
>
> >
> > By the way, I do see a merit on the "check" side (tl;dr: but I do
> > not think "result" needs it, hence I do not see the need for the
> > "ugly" variants).
>
> So we'd rather go with const char **result instead of our own new struct
On Fri, Oct 14, 2016 at 8:37 AM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> *1* Would we need a wrapping struct around the array of results?
>
> By the way, I do see a merit on the "check" side (tl;dr: but I do
> not think "result" needs it, hence I do not see the need for the
> "ugly" v
Junio C Hamano writes:
> *1* Would we need a wrapping struct around the array of results?
By the way, I do see a merit on the "check" side (tl;dr: but I do
not think "result" needs it, hence I do not see the need for the
"ugly" variants).
Take "archive" for example. For each path, it wants to
> On Wed, Oct 12, 2016 at 4:33 PM, Junio C Hamano wrote:
> so I am hoping that we won't have to do this uglier variant
---8<--- attr.h:
...
struct git_attr_result {
int check_nr;
/* Whether is was statically allocated and cannot be resized. */
int static_alloc;
const char *value[F
On Wed, Oct 12, 2016 at 4:33 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> @@ -89,15 +114,20 @@ static void setup_check(void)
>>
>>
>> const char *path;
>> + struct git_attr_result *result;
>>
>> setup_check();
>> - git_check_attr(path, check);
>> +
Stefan Beller writes:
> @@ -89,15 +114,20 @@ static void setup_check(void)
>
>
> const char *path;
> + struct git_attr_result *result;
>
> setup_check();
> - git_check_attr(path, check);
> + result = git_check_attr(path, check);
This looks stale by a few
8 matches
Mail list logo
