Re: [RFC/PATCH 1/3] mailinfo: refactor commit message processing

2016-09-16 Thread Jeff King
On Fri, Sep 16, 2016 at 12:12:50PM -0700, Junio C Hamano wrote: > > +static int check_header_raw(struct mailinfo *mi, > > + char *buf, size_t len, > > + struct strbuf *hdr_data[], int overwrite) { > > + const struct strbuf sb = {0, len, buf}; > > + r

Re: [RFC/PATCH 1/3] mailinfo: refactor commit message processing

2016-09-16 Thread Junio C Hamano
Jonathan Tan writes: > Within the processing of the commit message, check for a scissors line > or a patchbreak line first (before checking for in-body headers) so that > a subsequent patch modifying the processing of in-body headers would not > cause a scissors line or patchbreak line to be misi