On Sat, Nov 17, 2012 at 02:38:16AM +0100, Felipe Contreras wrote: > Instead of passing a dummy "", let's check if the last character is a > space, and then move the _cword accordingly. > > Apparently we were passing "" all the way to compgen, which fortunately > expanded it to nothing.
Glad you noticed it, too. I posted an alternative fix (without any new conditions in the code path) a while ago: http://article.gmane.org/gmane.comp.version-control.git/206525 Will repost it as part of my series shortly. > Lets do the right thing though. > > Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com> > --- > t/t9902-completion.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh > index cbd0fb6..0b5e1f5 100755 > --- a/t/t9902-completion.sh > +++ b/t/t9902-completion.sh > @@ -51,6 +51,7 @@ run_completion () > local _cword > _words=( $1 ) > (( _cword = ${#_words[@]} - 1 )) > + test "${1: -1}" == ' ' && (( _cword += 1 )) > __git_wrap__git_main && print_comp > } > > @@ -156,7 +157,7 @@ test_expect_success '__gitcomp - suffix' ' > ' > > test_expect_success 'basic' ' > - run_completion "git \"\"" && > + run_completion "git " && > # built-in > grep -q "^add \$" out && > # script > -- > 1.8.0 > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
