Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Thu, Aug 4, 2016 at 10:20 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> Hey Junio, >> >> On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano wrote: >>> Pranit Bauva writes: >>> > Also

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Pranit Bauva writes: > Hey Junio, > > On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano wrote: >> Pranit Bauva writes: >> Also you do not seem to check the error from the function to smudge the "result" you are returning

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >>> Also you do not seem to check the error from the function to smudge >>> the "result" you are returning from this function. >> >> Yes I should combine the

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Pranit Bauva writes: >> Also you do not seem to check the error from the function to smudge >> the "result" you are returning from this function. > > Yes I should combine the results from every removal. > >> Isn't unlink_or_warn() more correct helper to use here? > > The

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Tue, Aug 2, 2016 at 11:16 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int bisect_clean_state(void) >> +{ >> + int result = 0; >> + >> + /* There may be some refs packed during bisection */ >> + struct

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Pranit Bauva writes: > +static int bisect_clean_state(void) > +{ > + int result = 0; > + > + /* There may be some refs packed during bisection */ > + struct string_list refs_for_removal = STRING_LIST_INIT_NODUP; > + for_each_ref_in("refs/bisect/",