Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-03-25 Thread Torsten Bögershausen
On 24.03.13 03:49, Eric Sunshine wrote: > On Sat, Mar 23, 2013 at 8:40 AM, Torsten Bögershausen wrote: >> Subject: [PATCH] Make core.sharedRepository work under cygwin 1.7 [..] > > s/failes/fails/ > Thanks for review, I will send a new patch in a minute. It is actually 2 patches, - The fix as d

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-03-23 Thread Eric Sunshine
On Sat, Mar 23, 2013 at 8:40 AM, Torsten Bögershausen wrote: > Subject: [PATCH] Make core.sharedRepository work under cygwin 1.7 > > When core.sharedRepository is used, set_shared_perm() in path.c > needs lstat() to return the correct POSIX permissions. > > The default for cygwin is core.ignoreCyg

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-03-23 Thread Torsten Bögershausen
On 19.03.13 22:03, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> Use a compile switch IGNORECYGWINFSTRICKS to disable the usage >> of cygwin_lstat_fn() only in path.c > > The analysis of the problem and the basic idea to disable the > fast-but-lying fstricks in the code that matters

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-03-19 Thread Junio C Hamano
Junio C Hamano writes: > Torsten Bögershausen writes: > >> Use a compile switch IGNORECYGWINFSTRICKS to disable the usage >> of cygwin_lstat_fn() only in path.c > > The analysis of the problem and the basic idea to disable the > fast-but-lying fstricks in the code that matters may be good, but >

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-03-19 Thread Junio C Hamano
Torsten Bögershausen writes: > Use a compile switch IGNORECYGWINFSTRICKS to disable the usage > of cygwin_lstat_fn() only in path.c The analysis of the problem and the basic idea to disable the fast-but-lying fstricks in the code that matters may be good, but the implementation is questionable.

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-03-19 Thread Torsten Bögershausen
On Friday 08 February 2013 07:08:14 Torsten Bögershausen wrote: > On 07.02.13 20:35, Junio C Hamano wrote: > > Ramsay Jones writes: > > > >> Torsten Bögershausen wrote: > >>> t0070 and t1301 fail when running the test suite under cygwin. > >>> Skip the failing tests by unsetting POSIXPERM. > >> t1

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-02-07 Thread Torsten Bögershausen
On 07.02.13 20:35, Junio C Hamano wrote: > Ramsay Jones writes: > >> Torsten Bögershausen wrote: >>> t0070 and t1301 fail when running the test suite under cygwin. >>> Skip the failing tests by unsetting POSIXPERM. >> t1301 does not fail for me. (WIN XP (SP3) on NTFS) > Others run Cygwin with vfat

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-02-07 Thread Junio C Hamano
Ramsay Jones writes: > Torsten Bögershausen wrote: >> t0070 and t1301 fail when running the test suite under cygwin. >> Skip the failing tests by unsetting POSIXPERM. > > t1301 does not fail for me. (WIN XP (SP3) on NTFS) Others run Cygwin with vfat or some other filesystem, and some of them do

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-02-07 Thread Ramsay Jones
Torsten Bögershausen wrote: > t0070 and t1301 fail when running the test suite under cygwin. > Skip the failing tests by unsetting POSIXPERM. t1301 does not fail for me. (WIN XP (SP3) on NTFS) [It's so long since I looked, but I'm pretty sure that the failure in t0070 is caused by *git*, not by cy

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-02-06 Thread Torsten Bögershausen
Am 2013-02-06 10:34, schrieb Erik Faye-Lund: On Sun, Jan 27, 2013 at 3:57 PM, Torsten Bögershausen wrote: t0070 and t1301 fail when running the test suite under cygwin. Skip the failing tests by unsetting POSIXPERM. But is this the real reason? I thought Cygwin implemented POSIX permissions.

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-02-06 Thread Erik Faye-Lund
On Sun, Jan 27, 2013 at 3:57 PM, Torsten Bögershausen wrote: > t0070 and t1301 fail when running the test suite under cygwin. > Skip the failing tests by unsetting POSIXPERM. > But is this the real reason? I thought Cygwin implemented POSIX permissions...? -- To unsubscribe from this list: send t