Re: [RFC PATCH 04/10] ewah/bitmap: always allocate 2 more words

2019-10-11 Thread Jeff King
On Fri, Oct 11, 2019 at 09:49:53AM +0200, Christian Couder wrote: > > I think this should be squashed with patch 3, adding to that commit > > message "since word_alloc might be 0, we need to change the growth > > function". (Or just make the minimum word_alloc be 1 or 32 or something > > positive,

Re: [RFC PATCH 04/10] ewah/bitmap: always allocate 2 more words

2019-10-11 Thread Christian Couder
On Fri, Oct 11, 2019 at 1:40 AM Jonathan Tan wrote: > > > From: Jeff King > > > > In a following patch we will allocate a variable number > > of words in some bitmaps. When iterating over the words we > > will need a mark to tell us when to stop iterating. Let's > > always allocate 2 more words,

Re: [RFC PATCH 04/10] ewah/bitmap: always allocate 2 more words

2019-10-10 Thread Jonathan Tan
> From: Jeff King > > In a following patch we will allocate a variable number > of words in some bitmaps. When iterating over the words we > will need a mark to tell us when to stop iterating. Let's > always allocate 2 more words, that will always contain 0, > as that mark. [snip] > if (b