Re: [minor] two tests broken when run with a --root directory that's a symlink

[Junio C Hamano]

Michael Haggerty  writes:

> I ran into the same problem a while ago, and submitted a patch series
> that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):
>
> http://thread.gmane.org/gmane.comp.version-control.git/206633
>
> Junio didn't like the approach so much and I haven't yet had time to
> submit a revised version.

I like the approach of comparing each element of CEILING and the
directory not before but after resolving any symlinks in them.

My comments was only about the implementation that seemed to make
the API layering boundary more complex than necessary.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [minor] two tests broken when run with a --root directory that's a symlink

[Michael Haggerty]

On 10/11/2012 11:55 PM, Ævar Arnfjörð Bjarmason wrote:
> These issues are minor, I noticed it because I test with /dev/shm/git
> as the --root, which on Debian is symlinked to /run/..
> 
> $ rm -rf /tmp/{foo,bar}
> $ mkdir /tmp/target; ln -s /tmp/target /tmp/link
> $ prove ./t4035-diff-quiet.sh ./t9903-bash-prompt.sh :: --root=/tmp/target
> ./t4035-diff-quiet.sh ... ok
> ./t9903-bash-prompt.sh .. ok
> All tests successful.
> Files=2, Tests=64,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.07
> cusr  0.06 csys =  0.17 CPU)
> Result: PASS
> $ prove ./t4035-diff-quiet.sh ./t9903-bash-prompt.sh :: --root=/tmp/link
> ./t4035-diff-quiet.sh ... Dubious, test returned 1 (wstat 256, 0x100)
> Failed 3/20 subtests
> ./t9903-bash-prompt.sh .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 6/44 subtests
> 
> Everything else in the test suite passes with a --root that's a symlink.

I ran into the same problem a while ago, and submitted a patch series
that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):

http://thread.gmane.org/gmane.comp.version-control.git/206633

Junio didn't like the approach so much and I haven't yet had time to
submit a revised version.

Michael

-- 
Michael Haggerty
mhag...@alum.mit.edu
http://softwareswirl.blogspot.com/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html