Re: [msysGit] Re: [PATCH/RFC] test-lib: add support for colors without tput

2012-09-14 Thread Johannes Sixt 
Am 14.09.2012 18:58, schrieb Erik Faye-Lund:
   tput () {
   case $1 in
   bold)
 - echo -ne \033[1m ;;
 + printf \033[1m ;;
   setaf)
 - echo -ne \033[0;3$2m ;;
 + printf \033[0;3$2m ;;

This should be
printf '\033[0;3%sm' $2 ;;

   sgr0)
 - echo -ne \033(\033[m ;;
 + printf \033(\033[m ;;
   esac
   }
  fi

Did you test this only in rxvt or in CMD as well? (I hadn't time to
test, yet, so I'm asking :-)

-- Hannes

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [msysGit] Re: [PATCH/RFC] test-lib: add support for colors without tput

2012-09-14 Thread Erik Faye-Lund 
On Fri, Sep 14, 2012 at 7:28 PM, Johannes Sixt j...@kdbg.org wrote:
 Am 14.09.2012 18:58, schrieb Erik Faye-Lund:
   tput () {
   case $1 in
   bold)
 - echo -ne \033[1m ;;
 + printf \033[1m ;;
   setaf)
 - echo -ne \033[0;3$2m ;;
 + printf \033[0;3$2m ;;

 This should be
 printf '\033[0;3%sm' $2 ;;


That's probably a good idea, yeah.

   sgr0)
 - echo -ne \033(\033[m ;;
 + printf \033(\033[m ;;
   esac
   }
  fi

 Did you test this only in rxvt or in CMD as well? (I hadn't time to
 test, yet, so I'm asking :-)

I don't have rxvt installed, but it works for me in CMD also.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [msysGit] Re: [PATCH/RFC] test-lib: add support for colors without tput

2012-09-14 Thread Johannes Sixt 
Am 14.09.2012 20:11, schrieb Erik Faye-Lund:
 On Fri, Sep 14, 2012 at 7:28 PM, Johannes Sixt j...@kdbg.org wrote:
 printf '\033[0;3%sm' $2 ;;
 
 Is there a reason for %s rather than %d? It seem it only takes
 integers,..

No reason. I just mechanically converted your original expression. But
there is no reason for my conversion, either, if it can be more or less
guaranteed that no arbitrary strings are passed in $2.

-- Hannes

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html