Hi Stephan, Am 04.06.2014 14:42, schrieb Stepan Kasal: > On Wed, Jun 04, 2014 at 02:13:44PM +0200, Thomas Braun wrote: >> Wouldn't a function like test_cmp_bin() be better suited for all? > > I also considered it. The advantage is that is shows that > this intentionally differs from test_cmp. > >> The windows folks can then use cmp inside test_cmp_bin() and all others > > ... would use cmp as well because it is better suited for the task > than diff -u. So test_cmp_bin would be just an alias for cmp, on all > platforms. Doesn't that sound weird?
I actually like the idea that the test assertions follow a common naming scheme and can easily be overriden by $arbitrary-crazy-platform. Using test_cmp_bin instead of cmp would result in then four assertions for comparing arbitrary data test_cmp test_18ncmp test_cmp_text test_cmp_bin where I think the purpose of each function is clear from its name. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
