Re: [msysGit] Re: [PATCH 0/5] First part of Unicode console support for msysgit

2014-06-06 Thread Stepan Kasal
Hello,

On Fri, Jun 06, 2014 at 07:44:33PM +0200, Karsten Blees wrote:
> > Karsten Blees (5):
> >   Support Unicode console output on Windows
> 
> [..] you could have squashed half of
> "Win32: fix segfault in WriteConsoleW when debugging in gdb" [2] (second  
> half in [5/5]).
> 
> >   Detect console streams more reliably on Windows
> >   Warn if the Windows console font doesn't support Unicode
> 
> I think this one includes
> "MSVC: fix winansi.c compile errors " [3] and
> "Unicode console: fix font warning on Vista and Win7" [4]
[...]
> >   Win32: move main macro to a function
> >   Win32: Thread-safe windows console output

> [2] https://github.com/msysgit/git/commit/cd0792af
> [3] https://github.com/msysgit/git/commit/3abcb04d
> [4] https://github.com/msysgit/git/commit/981aa538

Indeed, you identified them correctly.  And [2] is actually squashed
in [5/5]; I think I can keep it that way.

I'll add the missing fix, take care about original dates, improve the
cover letter (the above links), and resubmit.

Thanks for review this batch of your patches.

Regards,
Stepan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [msysGit] Re: [PATCH 0/5] First part of Unicode console support for msysgit

2014-06-06 Thread Stepan Kasal
Hello Karsten,

On Fri, Jun 06, 2014 at 07:44:33PM +0200, Karsten Blees wrote:
> Nicely done, thanks!

thank you for your kind words.

Please hold back, I will re-submit in a few days.

> Note: this one was submitted seperately on May 29 and May 1 (can't
> find it in the gmane archive, though).

It was cc'ed to msysgit as usual and gmane selected it as the primary
place to store it:
http://thread.gmane.org/gmane.comp.version-control.msysgit/20324

regards,
Stepan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html