Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files

2012-10-18 Thread Thomas Ackermann 
 

 That means that for the patch [6/8], which adds content-type to the
 text files, to be complete, it needs to update Makefile to produce
 html files from them.
 

IMHO also for the new files in ./technical html should be created because
now as we have asciidoc markup why not also use it.


  BTW2: The 'pretty-print shell script in update-hook-example.txt'
  part of my changes was left out from the merge to pu ...
 
 Do you mean e2399e9 (Documentation/howto: convert plain text files
 to asciidoc, 2012-10-16), or something else?

Yes; in e2399e9 the following hunks where left out from the patch to 
update-hook-example.txt:

@@ -111,12 +114,12 @@ then
 
   info Found matching head pattern: '$head_pattern'
   for user_pattern in $user_patterns; do
-   info Checking user: '$username' against pattern: '$user_pattern'
-   matchlen=$(expr $username : $user_pattern)
-   if test $matchlen = ${#username}
-   then
- grant Allowing user: '$username' with pattern: '$user_pattern'
-   fi
+info Checking user: '$username' against pattern: '$user_pattern'
+matchlen=$(expr $username : $user_pattern)
+if test $matchlen = ${#username}
+then
+  grant Allowing user: '$username' with pattern: '$user_pattern'
+fi
   done
   deny The user is not in the access list for this branch
 done
@@ -149,13 +152,13 @@ then
 
   info Found matching head pattern: '$head_pattern'
   for group_pattern in $group_patterns; do
-   for groupname in $groups; do
- info Checking group: '$groupname' against pattern: '$group_pattern'
- matchlen=$(expr $groupname : $group_pattern)
- if test $matchlen = ${#groupname}
- then
-   grant Allowing group: '$groupname' with pattern: '$group_pattern'
- fi
+for groupname in $groups; do
+  info Checking group: '$groupname' against pattern: '$group_pattern'
+  matchlen=$(expr $groupname : $group_pattern)
+  if test $matchlen = ${#groupname}
+  then
+grant Allowing group: '$groupname' with pattern: '$group_pattern'
+  fi
 done
   done
   deny None of the user's groups are in the access list for this branch



---
Thomas
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files

2012-10-18 Thread Junio C Hamano 
Thomas Ackermann th.acke...@arcor.de writes:

 Yes; in e2399e9 the following hunks where left out from the patch to 
 update-hook-example.txt:

 @@ -111,12 +114,12 @@ then
  
info Found matching head pattern: '$head_pattern'
for user_pattern in $user_patterns; do
 - info Checking user: '$username' against pattern: '$user_pattern'
 - matchlen=$(expr $username : $user_pattern)
 - if test $matchlen = ${#username}
 - then
 -   grant Allowing user: '$username' with pattern: '$user_pattern'
 - fi
 +info Checking user: '$username' against pattern: '$user_pattern'
 +matchlen=$(expr $username : $user_pattern)
 +if test $matchlen = ${#username}
 +then
 +  grant Allowing user: '$username' with pattern: '$user_pattern'
 +fi
done
deny The user is not in the access list for this branch
  done
 @@ -149,13 +152,13 @@ then
  
info Found matching head pattern: '$head_pattern'
for group_pattern in $group_patterns; do
 - for groupname in $groups; do
 -   info Checking group: '$groupname' against pattern: '$group_pattern'
 -   matchlen=$(expr $groupname : $group_pattern)
 -   if test $matchlen = ${#groupname}
 -   then
 - grant Allowing group: '$groupname' with pattern: '$group_pattern'
 -   fi
 +for groupname in $groups; do
 +  info Checking group: '$groupname' against pattern: 
 '$group_pattern'
 +  matchlen=$(expr $groupname : $group_pattern)
 +  if test $matchlen = ${#groupname}
 +  then
 +grant Allowing group: '$groupname' with pattern: 
 '$group_pattern'
 +  fi
  done
done
deny None of the user's groups are in the access list for this branch

Yuck.  That is because I almost always apply patches with whitespace
breakage fix.  The above two hunks, if taken as patches to shell
script, does nothing but adding whitespace breakages, turning tab
indent into expanded runs of spaces, and that was why the tool
dropped them.

Resurrected; will queue the result later.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files

2012-10-17 Thread Junio C Hamano 
Thomas Ackermann th.acke...@arcor.de writes:

 BTW1: As only the changes in the doc files where cherry-picked, currently on 
 pu howto-index.sh
 will create invalid links in howto-index.html because it scans all .txt-files 
 in ./howto for 
 'Content-type: text/asciidoc' and if found, creates a reference to a html 
 file. But these are not created
 for the new asciidoc files. So the changes in Documentation/Makefile which 
 create html for the new  
 files should be merged also.

Ah, I didn't notice that.

That means that for the patch [6/8], which adds content-type to the
text files, to be complete, it needs to update Makefile to produce
html files from them.

Thanks.

 BTW2: The 'pretty-print shell script in update-hook-example.txt'
 part of my changes was left out from the merge to pu ...

Do you mean e2399e9 (Documentation/howto: convert plain text files
to asciidoc, 2012-10-16), or something else?
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html