Re: Patch Series v3 for use the $( ... ) construct for command substitution

2014-04-04 Thread Jonathan Nieder
Hi, Elia Pinto wrote: This patch series contain the use the $( ... ) construct for command substitution patches not already merged in ep/shell-command-substitution in the mantainer repository. Thanks for working on this. The $() form is less error-prone than ``, so in that sense it can

Re: Patch Series v3 for use the $( ... ) construct for command substitution

2014-04-04 Thread Matthieu Moy
Jonathan Nieder jrnie...@gmail.com writes: If the script is obviously correct enough then there is no need to manually go through 140 files after that point. The script cannot be obviously correct, as there are a lot of potential corner-cases (nested `, nesting ` within , comments, ...). If

Re: Patch Series v3 for use the $( ... ) construct for command substitution

2014-04-04 Thread Jonathan Nieder
Matthieu Moy wrote: Jonathan Nieder jrnie...@gmail.com writes: If the script is obviously correct enough then there is no need to manually go through 140 files after that point. The script cannot be obviously correct, as there are a lot of potential corner-cases (nested `, nesting ` within

Re: Patch Series v3 for use the $( ... ) construct for command substitution

2014-04-04 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: 140 patches worth of churn once every couple of years is not terrible, but I really don't want to see this becoming a pattern. :/ Likewise. And I don't see how the upside in this example warrants it. Paraphrasing