Re: Two bugs in --pretty with %C(auto)

2016-10-01 Thread Anatoly Borodin
Hi René, On Thu, Sep 29, 2016 at 8:13 PM, René Scharfe wrote: > Reverts the change to t6006, so we'd need another test for this. > Anatoly? :) I've checked my example commands and couldn't find any regressions. -- Mit freundlichen Grüßen, Anatoly Borodin

Re: Two bugs in --pretty with %C(auto)

2016-09-29 Thread René Scharfe
Am 17.09.2016 um 20:25 schrieb René Scharfe: > diff --git a/pretty.c b/pretty.c > index 9788bd8..493edb0 100644 > --- a/pretty.c > +++ b/pretty.c > @@ -1072,6 +1072,8 @@ static size_t format_commit_one(struct strbuf *sb, /* > in UTF-8 */ > case 'C': > if

Re: Two bugs in --pretty with %C(auto)

2016-09-19 Thread Duy Nguyen
On Sun, Sep 18, 2016 at 1:25 AM, René Scharfe wrote: > Am 17.09.2016 um 14:51 schrieb Anatoly Borodin: >> Hi All! >> >> First bug: >> >> git log -3 --pretty='%C(cyan)%C(auto)%h%C(auto)%d %s' >> >> prints %h with the default color (normal yellow), but >> >> git log -3

Re: Two bugs in --pretty with %C(auto)

2016-09-18 Thread René Scharfe
Am 18.09.2016 um 14:30 schrieb Anatoly Borodin: On Sat, Sep 17, 2016 at 8:25 PM, René Scharfe wrote: I'm not sure how just how automatic %C(auto) is supposed to be, but you expected it do emit the reset for you, right? Sounds reasonable to me. I don't see a good reason not to

Re: Two bugs in --pretty with %C(auto)

2016-09-18 Thread Anatoly Borodin
Hi René! On Sat, Sep 17, 2016 at 8:25 PM, René Scharfe wrote: > I'm not sure how just how automatic %C(auto) is supposed to be, but you > expected it do emit the reset for you, right? Sounds reasonable to me. I don't see a good reason not to do so. Spare some bytes?.. > The

Re: Two bugs in --pretty with %C(auto)

2016-09-17 Thread René Scharfe
Am 17.09.2016 um 14:51 schrieb Anatoly Borodin: > Hi All! > > First bug: > > git log -3 --pretty='%C(cyan)%C(auto)%h%C(auto)%d %s' > > prints %h with the default color (normal yellow), but > > git log -3 --pretty='%C(bold cyan)%C(auto)%h%C(auto)%d %s' > > shows %h with bold