Re: Use of a mailmap file with git-log

2012-12-10 Thread Junio C Hamano
Rich Midwinter rich.midwin...@gmail.com writes: I'm working on a project for a large organisation that wants to make widespread use of git and the mailmap feature. This seems to be supported by default in git-shortlog but not git-log (and other variants) without specifying custom formats,

Re: Use of a mailmap file with git-log

2012-12-10 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Rich Midwinter rich.midwin...@gmail.com writes: I'm working on a project for a large organisation that wants to make widespread use of git and the mailmap feature. This seems to be supported by default in git-shortlog but not git-log (and other

Re: Use of a mailmap file with git-log

2012-12-10 Thread Antoine Pelisse
Hi, I was thinking about that last week. It could indeed be very interesting to have mailmap applied to git-log and especially to git-log --author/--committer. My first look at the code let me think that we would need to change the parse_commit_buffer to replace, at reading time, the name of

Re: Use of a mailmap file with git-log

2012-12-10 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: Yet I'm afraid it could be: 1. expensive to rewrite all commit log (reallocating the buffer) 2. Inappropriate to change the value in function that is supposed to read In my suggestion I avoided rewriting the log buffer, primarily because of #2 (in

Re: Use of a mailmap file with git-log

2012-12-10 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: It could indeed be very interesting to have mailmap applied to git-log and especially to git-log --author/--committer. ... The choice of parse_commit_buffer to do the modification is due to the grepping being done directly on buffer when grepping