Re: What's cooking in git.git (Dec 2013, #01; Wed, 4)

2013-12-05 Thread Junio C Hamano
Duy Nguyen  writes:

> On Thu, Dec 5, 2013 at 8:23 AM, Junio C Hamano  wrote:
>> * aa/transport-non-positive-depth-only (2013-11-26) 1 commit
>>   (merged to 'next' on 2013-11-27 at b01f05b)
>>  + transport: catch non positive --depth option value
>>
>>  Will merge to 'master'.
>
> Don't. It breaks smart-http [1]. I'm starting to think catching this
> at fetch/clone level is probably better. But I need to add a test case
> to exercise this backfill_tags code in smart-http first.
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/238714/focus=238720

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: What's cooking in git.git (Dec 2013, #01; Wed, 4)

2013-12-04 Thread Christian Couder
On Thu, Dec 5, 2013 at 2:23 AM, Junio C Hamano  wrote:
>
> * cc/starts-n-ends-with (2013-12-04) 4 commits
>  - replace {pre,suf}fixcmp() with {starts,ends}_with()
>  - strbuf: introduce starts_with() and ends_with()
>  - builtin/remote: remove postfixcmp() and use suffixcmp() instead
>  - environment: normalize use of prefixcmp() by removing " != 0"
>  (this branch is used by cc/starts-n-ends-with-endgame.)
>
>  Remove a few duplicate implementations of prefix/suffix comparison
>  functions, and rename them to starts_with and ends_with.
>
>  This conflicts with a part of cc/remote-remove-redundant-postfixcmp
>  topic (I think it actually subsumes it).

Yeah, it subsumes it.

Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: What's cooking in git.git (Dec 2013, #01; Wed, 4)

2013-12-04 Thread Duy Nguyen
On Thu, Dec 5, 2013 at 8:23 AM, Junio C Hamano  wrote:
> * aa/transport-non-positive-depth-only (2013-11-26) 1 commit
>   (merged to 'next' on 2013-11-27 at b01f05b)
>  + transport: catch non positive --depth option value
>
>  Will merge to 'master'.

Don't. It breaks smart-http [1]. I'm starting to think catching this
at fetch/clone level is probably better. But I need to add a test case
to exercise this backfill_tags code in smart-http first.

[1] http://thread.gmane.org/gmane.comp.version-control.git/238714/focus=238720
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html