Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread Ramkumar Ramachandra
David Kastrup wrote: As you can see, the first message starting with error: could not apply outputs a reasonable rendition of the commit summary line. However, the final Could not apply message (starting with a capital C) converts instances of \t to a tab. To get you started: $ git grep

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread Matthieu Moy
David Kastrup d...@gnu.org writes: Could not apply 16de9d2... Make tempo range empo 20~30 be input as empo 20-30 instead Indeed. The source of the problem is that our die shell function interprets \t (because it uses echo). A simple fix would be this: diff --git a/git-sh-setup.sh

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread David Kastrup
Matthieu Moy matthieu@grenoble-inp.fr writes: David Kastrup d...@gnu.org writes: Could not apply 16de9d2... Make tempo range empo 20~30 be input as empo 20-30 instead Indeed. The source of the problem is that our die shell function interprets \t (because it uses echo). A simple fix

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread Matthieu Moy
David Kastrup d...@gnu.org writes: diff --git a/git-sh-setup.sh b/git-sh-setup.sh index 7a964ad..97258d5 100644 --- a/git-sh-setup.sh +++ b/git-sh-setup.sh @@ -53,7 +53,7 @@ die () { die_with_status () { status=$1 shift - echo 2 $* + printf 2 %s\n $*

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: So, it's the shell script. Now, read about shell escaping [1] and submit a patch. This is not about shell escaping at all. I think the message is fed to echo as-is, or to printf as its first parameter. -- To unsubscribe from this list: send the

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: David Kastrup d...@gnu.org writes: Could not apply 16de9d2... Make tempo range empo 20~30 be input as empo 20-30 instead Indeed. The source of the problem is that our die shell function interprets \t (because it uses echo). A simple

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread David Kastrup
Matthieu Moy matthieu@grenoble-inp.fr writes: From 7962ac8d8f2cbc556f669fd97487f9d70edc4ea1 Mon Sep 17 00:00:00 2001 From: Matthieu Moy matthieu@imag.fr Date: Tue, 6 Aug 2013 19:13:03 +0200 Subject: [PATCH] die_with_status: use printf '%s\n', not echo At least GNU echo interprets

Re: git rebase -i error message interprets \t in commit message

2013-08-06 Thread Junio C Hamano
David Kastrup d...@gnu.org writes: Matthieu Moy matthieu@grenoble-inp.fr writes: From 7962ac8d8f2cbc556f669fd97487f9d70edc4ea1 Mon Sep 17 00:00:00 2001 From: Matthieu Moy matthieu@imag.fr Date: Tue, 6 Aug 2013 19:13:03 +0200 Subject: [PATCH] die_with_status: use printf '%s\n', not