Re: insteadOf and git-request-pull output

2018-11-22 Thread Jeff King
On Sat, Nov 17, 2018 at 11:07:32PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > I suspect it would be less confusing if the rewrite were inverted, like: > > > > [url "gh:"] > > rewriteTo = https://github.com > > rewritePrivate > > > > [url "git://github.com"] > > rewriteTo =

Re: insteadOf and git-request-pull output

2018-11-17 Thread Junio C Hamano
Jeff King writes: > I suspect it would be less confusing if the rewrite were inverted, like: > > [url "gh:"] > rewriteTo = https://github.com > rewritePrivate > > [url "git://github.com"] > rewriteTo = https://github.com > > where the mapping of sections to rewrite rules must be

Re: insteadOf and git-request-pull output

2018-11-17 Thread Jeff King
On Sat, Nov 17, 2018 at 04:46:22PM +0900, Junio C Hamano wrote: > "brian m. carlson" writes: > > >> $ git request-pull HEAD^ git://foo.example.com/example | grep example > >> ssh://bar.example.com/example > >> > >> I think that if we use the "principle of least surprise," insteadOf > >>

Re: insteadOf and git-request-pull output

2018-11-16 Thread Junio C Hamano
"brian m. carlson" writes: >> $ git request-pull HEAD^ git://foo.example.com/example | grep example >> ssh://bar.example.com/example >> >> I think that if we use the "principle of least surprise," insteadOf >> rules shouldn't be applied for git-request-pull URLs. > > I'd like to point out a

Re: insteadOf and git-request-pull output

2018-11-16 Thread brian m. carlson
On Thu, Nov 15, 2018 at 01:28:26PM -0500, Konstantin Ryabitsev wrote: > Hi, all: > > Looks like setting url.insteadOf rules alters the output of > git-request-pull. I'm not sure that's the intended use of insteadOf, > which is supposed to replace URLs for local use, not to expose them > publicly

Re: insteadOf and git-request-pull output

2018-11-15 Thread Junio C Hamano
Konstantin Ryabitsev writes: > On Thu, Nov 15, 2018 at 07:54:32PM +0100, Ævar Arnfjörð Bjarmason wrote: >> > I think that if we use the "principle of least surprise," insteadOf >> > rules shouldn't be applied for git-request-pull URLs. >> >> I haven't used request-pull so I don't have much of

Re: insteadOf and git-request-pull output

2018-11-15 Thread Konstantin Ryabitsev
On Thu, Nov 15, 2018 at 07:54:32PM +0100, Ævar Arnfjörð Bjarmason wrote: > > I think that if we use the "principle of least surprise," insteadOf > > rules shouldn't be applied for git-request-pull URLs. > > I haven't used request-pull so I don't have much of an opinion on this, > but do you think

Re: insteadOf and git-request-pull output

2018-11-15 Thread Ævar Arnfjörð Bjarmason
On Thu, Nov 15 2018, Konstantin Ryabitsev wrote: > Hi, all: > > Looks like setting url.insteadOf rules alters the output of > git-request-pull. I'm not sure that's the intended use of insteadOf, > which is supposed to replace URLs for local use, not to expose them > publicly (but I may be