Re: reftable [v2]: new ref storage format

2017-07-23 Thread Ævar Arnfjörð Bjarmason
On Sun, Jul 23 2017, Shawn Pearce jotted: > My apologies for not responding to this piece of feedback earlier. > > On Wed, Jul 19, 2017 at 7:02 AM, Ævar Arnfjörð Bjarmason > wrote: >> On Tue, Jul 18 2017, Shawn Pearce jotted: >>> On Mon, Jul 17, 2017 at 12:51 PM, Junio C

Re: reftable [v2]: new ref storage format

2017-07-23 Thread Shawn Pearce
My apologies for not responding to this piece of feedback earlier. On Wed, Jul 19, 2017 at 7:02 AM, Ævar Arnfjörð Bjarmason wrote: > On Tue, Jul 18 2017, Shawn Pearce jotted: >> On Mon, Jul 17, 2017 at 12:51 PM, Junio C Hamano wrote: >>> Shawn Pearce

Re: reftable [v2]: new ref storage format

2017-07-19 Thread Ævar Arnfjörð Bjarmason
On Tue, Jul 18 2017, Shawn Pearce jotted: > On Mon, Jul 17, 2017 at 12:51 PM, Junio C Hamano wrote: >> Shawn Pearce writes: >>> where `time_sec` is the update time in seconds since the epoch. The >>> `reverse_int32` function inverses the value so

Re: reftable [v2]: new ref storage format

2017-07-18 Thread Shawn Pearce
On Mon, Jul 17, 2017 at 12:51 PM, Junio C Hamano wrote: > Shawn Pearce writes: >> You can read a rendered version of this here: >> https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md > > Just a few comments. > >> A

Re: reftable [v2]: new ref storage format

2017-07-17 Thread Stefan Beller
On Mon, Jul 17, 2017 at 12:04 PM, Shawn Pearce wrote: > A block must have at least one restart in it, the first ref_record > must be a restart. So number_of_restarts in the tail of the block can > be 0, which implies 1 restart (number_of_restarts + 1), and the first >

Re: reftable [v2]: new ref storage format

2017-07-17 Thread Junio C Hamano
Shawn Pearce writes: > This is an updated draft after discussion on list with Peff, Michael > Haggerty, and Dave Borowitz. > > You can read a rendered version of this here: > https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md > >

Re: reftable [v2]: new ref storage format

2017-07-17 Thread Shawn Pearce
On Mon, Jul 17, 2017 at 11:53 AM, Stefan Beller wrote: > On Mon, Jul 17, 2017 at 8:01 AM, Shawn Pearce wrote: > >> A ref block is written as: >> >> 'r' >> uint24 ( block_len ) >> ref_record* >> uint32( restart_offset )* >> uint16(

Re: reftable [v2]: new ref storage format

2017-07-17 Thread Stefan Beller
On Mon, Jul 17, 2017 at 8:01 AM, Shawn Pearce wrote: > A ref block is written as: > > 'r' > uint24 ( block_len ) > ref_record* > uint32( restart_offset )* > uint16( number_of_restarts ) > padding? > ... > > The 2-byte `number_of_restarts + 1` stores