Re: small misspellings fixes
Matthieu Moy matthieu@grenoble-inp.fr writes: Veres Lajos vla...@gmail.com writes: I am trying to convert this pull request: https://github.com/git/git/pull/42 to a proper patch email Use git format-patch and/or git send-email to get the proper formatting. (Sorry If I miss something about the process.) Yes, your patch doesn't have exactly the right format, and you should have Cc-ed Junio (see Documentation/SubmittingPatches in Git's source tree). Other than that, the content of the patch looks good (and actually, at least one of the typos is mine :-( ). Can you resend? Repeating the subject in the body is unnecessary. I'll pick it up from here and will fix up. No need to resend. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: small misspellings fixes
Veres Lajos wrote: Subject: small misspelling fixes Good. I am trying to convert this pull request: https://github.com/git/git/pull/42 to a proper patch email (Sorry If I miss something about the process.) This does not belong in the commit message: you don't want this to be shown when someone is reading 'git log' output, do you? Put such comments under the -- line after the signoff, so it'll be ignored by git am. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: small misspellings fixes
Veres Lajos vla...@gmail.com writes: I am trying to convert this pull request: https://github.com/git/git/pull/42 to a proper patch email Use git format-patch and/or git send-email to get the proper formatting. (Sorry If I miss something about the process.) Yes, your patch doesn't have exactly the right format, and you should have Cc-ed Junio (see Documentation/SubmittingPatches in Git's source tree). Other than that, the content of the patch looks good (and actually, at least one of the typos is mine :-( ). Can you resend? Thanks, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
