Re: git grep -F (fixed string) requires matching parenthesis?

2019-08-13 Thread nanaya
On Tue, Aug 13, 2019, at 21:17, Jeff King wrote: > But I think it's actually happening at a level above that. git-grep > supports multiple patterns, which can be joined with --and, --or, --not, > etc. And they can be grouped with parentheses. > > What you're seeing is the argument parser thinki

Re: git grep -F (fixed string) requires matching parenthesis?

2019-08-13 Thread Jeff King
On Tue, Aug 13, 2019 at 03:01:04PM +0900, nanaya wrote: > I observed this today: > > $ git grep -F '(' > fatal: unmatched parenthesis > > Which doesn't make sense and I believe shouldn't happen. At first glance this looks like we're feeding a fixed-string pattern to the regex compiler, which wo

git grep -F (fixed string) requires matching parenthesis?

2019-08-12 Thread nanaya
Hi, I observed this today: $ git grep -F '(' fatal: unmatched parenthesis Which doesn't make sense and I believe shouldn't happen. $ git --version git version 2.22.0