On 01/16/2014 10:03, Jeff King wrote:
We used to print Reading from helper 'git-remote-https' failed in this
instance. But in the majority of cases, remote-https has printed a
useful message already to stderr, and the extra line just confused
people. The downside, as you noticed, is that when
Yuri y...@rawbw.com writes:
I think that in a rare case of error this extra-printout wouldn't
hurt.
If the error is rare, extra verbiage does not hurt were a valid
attitude, error is rare, non-zero exit is enough would be equally
valid ;-)
Also that statement contradicts with the rationale
On Fri, Jan 17, 2014 at 11:43:35AM -0800, Junio C Hamano wrote:
Yuri y...@rawbw.com writes:
I think that in a rare case of error this extra-printout wouldn't
hurt.
If the error is rare, extra verbiage does not hurt were a valid
attitude, error is rare, non-zero exit is enough would be
On Fri, Jan 17, 2014 at 03:13:25PM -0500, Jeff King wrote:
On Fri, Jan 17, 2014 at 11:43:35AM -0800, Junio C Hamano wrote:
Yuri y...@rawbw.com writes:
I think that in a rare case of error this extra-printout wouldn't
hurt.
If the error is rare, extra verbiage does not hurt were
On 01/17/2014 12:13, Jeff King wrote:
$ git clonehttps://google.com/foo.git
Cloning into 'foo'...
fatal: repository 'https://google.com/foo.git/' not found
fatal: Reading from helper 'git-remote-https' failed
That second line is not adding anything, and IMHO is making things
uglier
On Fri, Jan 17, 2014 at 12:39:39PM -0800, Yuri wrote:
That second line is not adding anything, and IMHO is making things
uglier and more confusing. We_expected_ the helper to hang up; that's
how it signals an error to us. It is not an unexpected condition at all.
The exit(128) we do is
On one of my FreeBSD systems I can't clone github through https URL.
It only says Cloning into 'MyProject'..., writes some files, but then
deletes everything, without printing anything else at all. Exit code is 128.
Replacing https:// with git:// makes it work fine.
While debugging, I find
On Thu, Jan 16, 2014 at 04:27:03AM -0800, Yuri wrote:
While debugging, I find that remove_junk() deletes all directories
from under __cxa_finalize.
Before this, exit(128) is called from recvline_fh (Debug: Remote
helper quit.) And this function in turn is called from under
refs =
On 01/16/2014 10:03, Jeff King wrote:
We used to print Reading from helper 'git-remote-https' failed in this
instance. But in the majority of cases, remote-https has printed a
useful message already to stderr, and the extra line just confused
people. The downside, as you noticed, is that when
9 matches
Mail list logo