[GitHub] [activemq-artemis-native] orpiske commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

orpiske commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340316928 ## File path:

[GitHub] [activemq-artemis-native] franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547614074 > Isn't there a new API that would perform the proper ring operations now? Maybe, I

[GitHub] [activemq-artemis-native] franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547614074 > Isn't there a new API that would perform the proper ring operations now? Maybe, I

[GitHub] [activemq-artemis-native] franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547614074 > Isn't there a new API that would perform the proper ring operations now? Maybe, I

[GitHub] [activemq-artemis-native] franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547614074 > Isn't there a new API that would perform the proper ring operations now? Maybe, I

[GitHub] [activemq-artemis-native] franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547614074 > Isn't there a new API that would perform the proper ring operations now? Maybe, I

[GitHub] [activemq-artemis-native] franz1981 commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547614074 > Isn't there a new API that would perform the proper ring operations now? Maybe, I need to

[GitHub] [activemq-artemis] dependabot[bot] opened a new pull request #2877: Bump netty.version from 4.1.34.Final to 4.1.43.Final

dependabot[bot] opened a new pull request #2877: Bump netty.version from 4.1.34.Final to 4.1.43.Final URL: https://github.com/apache/activemq-artemis/pull/2877 Bumps `netty.version` from 4.1.34.Final to 4.1.43.Final. Updates `netty-all` from 4.1.34.Final to 4.1.43.Final

[GitHub] [activemq-artemis] dependabot[bot] opened a new pull request #2875: Bump checkstyle from 7.7 to 8.18

dependabot[bot] opened a new pull request #2875: Bump checkstyle from 7.7 to 8.18 URL: https://github.com/apache/activemq-artemis/pull/2875 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 7.7 to 8.18. Release notes *Sourced from [checkstyle's

[GitHub] [activemq-artemis] dependabot[bot] opened a new pull request #2874: Bump org.eclipse.paho.client.mqttv3 from 1.1.0 to 1.2.1 in /tests/integration-tests

dependabot[bot] opened a new pull request #2874: Bump org.eclipse.paho.client.mqttv3 from 1.1.0 to 1.2.1 in /tests/integration-tests URL: https://github.com/apache/activemq-artemis/pull/2874 Bumps org.eclipse.paho.client.mqttv3 from 1.1.0 to 1.2.1. [![Dependabot compatibility

[GitHub] [activemq-artemis] dependabot[bot] opened a new pull request #2876: Bump activemq5-version from 5.14.5 to 5.15.10

dependabot[bot] opened a new pull request #2876: Bump activemq5-version from 5.14.5 to 5.15.10 URL: https://github.com/apache/activemq-artemis/pull/2876 Bumps `activemq5-version` from 5.14.5 to 5.15.10. Updates `activemq-client` from 5.14.5 to 5.15.10 Updates

[GitHub] [activemq-artemis] asfgit closed pull request #2870: ARTEMIS-2530 Upgrade ActiveMQ Artemis Native 1.0.1

asfgit closed pull request #2870: ARTEMIS-2530 Upgrade ActiveMQ Artemis Native 1.0.1 URL: https://github.com/apache/activemq-artemis/pull/2870 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame

Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547599630 @cjwmorgan-sol No it shouldn't. I've tried to reproduce what you did but with no

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame

Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547599630 @cjwmorgan-sol No it shouldn't. I've tried to reproduce what you did but with no

[GitHub] [activemq-artemis-native] clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-54766 Isn't there a new API that would perform the proper ring operations now? I understand you

[GitHub] [activemq-nms-amqp] Havret commented on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame

Havret commented on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547599630 @cjwmorgan-sol No it shouldn't. I've tried to reproduce what you did but with no lack.

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547275684 Ok, now it is more clear, thanks! So ByteBufs start to be accumulated due to

[GitHub] [activemq-artemis-native] franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 edited a comment on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547575936 The issue is the reordering performed by the processor: on x86 such operation won't get

[GitHub] [activemq-artemis-native] franz1981 commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547575936 The issue is the reordering performed by the processor: on x86 such operation won't get reordered

[GitHub] [activemq-artemis] asfgit closed pull request #2873: NO-JIRA add acceptor to handshake timeout msg

asfgit closed pull request #2873: NO-JIRA add acceptor to handshake timeout msg URL: https://github.com/apache/activemq-artemis/pull/2873 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis-native] clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547567197 From what I understand from the ring-queue implementation, the barrier is to prevent two

[GitHub] [activemq-artemis-native] clebertsuconic commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340253649 ## File path:

[GitHub] [activemq-artemis-native] clebertsuconic commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340253649 ## File path:

[GitHub] [activemq-artemis-native] clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547558006 @franz1981 Can't we leave this as is? looking on it now it seems :::memory is an instruction

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #46: AMQNET-623: Error logged during connection close when broker is down

michaelandrepearce merged pull request #46: AMQNET-623: Error logged during connection close when broker is down URL: https://github.com/apache/activemq-nms-amqp/pull/46 This is an automated message from the Apache Git

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #46: AMQNET-623: Error logged during connection close when broker is down

michaelandrepearce commented on issue #46: AMQNET-623: Error logged during connection close when broker is down URL: https://github.com/apache/activemq-nms-amqp/pull/46#issuecomment-547538966 LGTM, small change which seems safe, so just merging.

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame

cjwmorgan-sol commented on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547534912 Looks good and tests pass. The only thing is running

[GitHub] [activemq-artemis-native] clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on issue #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547533913 @franz1981 I have been using ./scripts/compile-using-docker.sh to compile upstream. As

[GitHub] [activemq-artemis-native] clebertsuconic commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

clebertsuconic commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340213644 ## File path:

[GitHub] [activemq-artemis-native] franz1981 commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

franz1981 commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340192651 ## File path:

[GitHub] [activemq-artemis-native] orpiske commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass

orpiske commented on a change in pull request #5: ARTEMIS-2533 Support multiple architecture for ASYNCIO kernel by-pass URL: https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340192351 ## File path:

[GitHub] [activemq-artemis-native] franz1981 commented on issue #5: ARTEMIS-2533

franz1981 commented on issue #5: ARTEMIS-2533 URL: https://github.com/apache/activemq-artemis-native/pull/5#issuecomment-547503120 I would like @clebertsuconic and @orpiske reviews for this :+1: This is an automated message

[GitHub] [activemq-artemis-native] franz1981 opened a new pull request #5: ARTEMIS-2533

franz1981 opened a new pull request #5: ARTEMIS-2533 URL: https://github.com/apache/activemq-artemis-native/pull/5 Support multiple architecture for ASYNCIO kernel by-pass This is an automated message from the Apache Git

[GitHub] [activemq-artemis] jbertram opened a new pull request #2873: NO-JIRA add acceptor to handshake timeout msg

jbertram opened a new pull request #2873: NO-JIRA add acceptor to handshake timeout msg URL: https://github.com/apache/activemq-artemis/pull/2873 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547275684 Ok, now it is more clear, thanks! So ByteBufs start to be accumulated due to FileRegions