Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043874595 I think that the behavior should match the destination policy. 1. Wildcard 2. Fully qualified name (authoritative) I agree, it should be a new flag since we would not

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043856614 The only other thing i can think of is we could technically change the behavior of the authorization broker plugin because you could make an argument that any matching wildcard should

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043790765 In terms of working around this, the options are pretty much: 1. If you are going to create topics then you need to make sure you have proper ACLs set up for those topics

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043752900 This is not really a bug to me, it's a side effect of how wild card subscriptions work in the broker. The issue here is not with the authorization plugin or logic but with how

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-08 Thread via GitHub
clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2043625204 @AntonRoskvist , @andytaylor can we settle with these changes? I added the "internal attribute" to the AddressControl as well. @andytaylor if you could

Re: [PR] ARTEMIS-4510 - Add auto-create-destination logic to diverts [activemq-artemis]

2024-04-08 Thread via GitHub
clebertsuconic closed pull request #4681: ARTEMIS-4510 - Add auto-create-destination logic to diverts URL: https://github.com/apache/activemq-artemis/pull/4681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] ARTEMIS-4717 Upgrade commons-configuration2 to 2.10.1 [activemq-artemis]

2024-04-08 Thread via GitHub
clebertsuconic merged PR #4877: URL: https://github.com/apache/activemq-artemis/pull/4877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ARTEMIS-4510 - Add auto-create-destination logic to diverts [activemq-artemis]

2024-04-08 Thread via GitHub
clebertsuconic commented on PR #4867: URL: https://github.com/apache/activemq-artemis/pull/4867#issuecomment-2043460610 actually.. I pushed a commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] ARTEMIS-4510 - Add auto-create-destination logic to diverts [activemq-artemis]

2024-04-08 Thread via GitHub
clebertsuconic closed pull request #4867: ARTEMIS-4510 - Add auto-create-destination logic to diverts URL: https://github.com/apache/activemq-artemis/pull/4867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] ARTEMIS-4717 Upgrade commons-configuration2 to 2.10.1 [activemq-artemis]

2024-04-08 Thread via GitHub
brusdev opened a new pull request, #4877: URL: https://github.com/apache/activemq-artemis/pull/4877 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ARTEMIS-4510 - Add auto-create-destination logic to diverts [activemq-artemis]

2024-04-08 Thread via GitHub
clebertsuconic commented on PR #4867: URL: https://github.com/apache/activemq-artemis/pull/4867#issuecomment-2042993128 @AntonRoskvist I pulled your changes, removed all the docs and stuff and pushed on main (I pushed as you). now you have to give a JIRA to your other change.

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2042861290 I was able to reproduce using a stock Apache v6.1.1 build. This appears to be a 'does not permit' issue and not a 'does not restrict' issue. -- This is an automated message from the

Re: [PR] ARTEMIS-4510 - Add auto-create-destination logic to diverts [activemq-artemis]

2024-04-08 Thread via GitHub
AntonRoskvist commented on PR #4867: URL: https://github.com/apache/activemq-artemis/pull/4867#issuecomment-2042323454 @clebertsuconic Sounds great, thanks! I went ahead and separated the changes. Let me know when/if you are happy with your testing (removing the config option