Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-09 Thread via GitHub
thezbyg commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2046523027 > So this is just how the broker currently works to handle wildcard subscriptions, since you are publishing to a wildcard topic then any subscription that matches needs to also

Re: [PR] ARTEMIS-4675 - Add replication status metrics [activemq-artemis]

2024-04-09 Thread via GitHub
asfgit closed pull request #4844: ARTEMIS-4675 - Add replication status metrics URL: https://github.com/apache/activemq-artemis/pull/4844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ARTEMIS-4715 using # wildcard from OpenWire JMS consumer stopped working [activemq-artemis]

2024-04-09 Thread via GitHub
clebertsuconic merged PR #4878: URL: https://github.com/apache/activemq-artemis/pull/4878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] ARTEMIS-4715 using # wildcard from OpenWire JMS consumer stopped working [activemq-artemis]

2024-04-09 Thread via GitHub
jbertram opened a new pull request, #4878: URL: https://github.com/apache/activemq-artemis/pull/4878 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ARTEMIS-4709 plugin to enforce connection periodic expiry per acceptor [activemq-artemis]

2024-04-09 Thread via GitHub
jbertram commented on PR #4871: URL: https://github.com/apache/activemq-artemis/pull/4871#issuecomment-2045717014 I've gone back and forth on this in my mind a few times. I see your points, but if this functionality "becomes part of lots of deployments" then changing the way it's

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
AntonRoskvist commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045712012 @clebertsuconic Yes the test is still passing so I suppose they are manageable, however at least from my own testing I have been unable to collect any metrics for both

Re: [PR] ARTEMIS-4709 plugin to enforce connection periodic expiry per acceptor [activemq-artemis]

2024-04-09 Thread via GitHub
gtully commented on code in PR #4871: URL: https://github.com/apache/activemq-artemis/pull/4871#discussion_r1557991812 ## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/impl/ConnectionPeriodicExpiryPlugin.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045639103 (I closed it by accident) @AntonRoskvist if you could take a look please? management on SNF still enabled per your tests. -- This is an automated message

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045594854 @AntonRoskvist we have management enabled on all the queues: basically your test is still here:

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
clebertsuconic closed pull request #4856: ARTEMIS-4498 - Expose internal queues for management and observability URL: https://github.com/apache/activemq-artemis/pull/4856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [AMQ-9474] Update activemq-osgi import for Spring 6 [activemq]

2024-04-09 Thread via GitHub
jbonofre commented on PR #1199: URL: https://github.com/apache/activemq/pull/1199#issuecomment-2045419981 I will merge as soon as Jenkins is happy ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] [AMQ-9474] Update activemq-osgi import for Spring 6 [activemq]

2024-04-09 Thread via GitHub
mattrpav opened a new pull request, #1199: URL: https://github.com/apache/activemq/pull/1199 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-09 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2045239359 Looking at the use case, I don't see a scenario where using a wildcard _topic_ makes the most sense. Topics already of subscriptions, so instead of creating additional _destinations_

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045191260 As far as I know I changed the SNF to always register management. What am I missing ? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045192210 I should be basically always registering any queue. Did I miss that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] ARTEMIS-4498 - Expose internal queues for management and observability [activemq-artemis]

2024-04-09 Thread via GitHub
AntonRoskvist commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2044391474 @clebertsuconic this doesn't quite do it for me as the change still leaves out management and metrics for the internal queues. In my use case I'm primarily looking for

Re: [PR] ARTEMIS-4510 - Add auto-create-destination logic to diverts [activemq-artemis]

2024-04-09 Thread via GitHub
AntonRoskvist commented on PR #4867: URL: https://github.com/apache/activemq-artemis/pull/4867#issuecomment-2044282712 @clebertsuconic Excellent, thanks for your fixes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use