[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local `ByteBuf`pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local `ByteBuf`pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530319911 @wy96f I've taken a second look to the way Netty handle thread local pools and I can confirm that

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they just

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530284944 @wy96f Yes and no :) They would leak (at first look, but let me take a better look), but they would

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530138441 @wy96f please take a look: I know you've recently have fun with `ByteBuf`s :) I see too that the change

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530076449 @clebertsuconic I still need to address few bits about it, so please don't merge it yet