Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-04-17 Thread via GitHub
cardamon commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-2061015235 FYI this introduces a breaking change that should probably be documented @

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-15 Thread via GitHub
gtully merged PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-14 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1998472976 @jbertram I think this is in a happy place if you have some cycles to peek again. thanks -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-14 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1997343935 And on update, there is a case for suggesting a publisher would need the update permission on an address to send a message, or a consumer could be updating by acking. It is not

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-14 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1997338325 new thought, the two prefixes for the security settings match, jmx and mgmt_msg will get in the way of doing filtering of aggregate operations like list* on a server control.

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-13 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1522897353 ## docs/user-manual/management.adoc: ## @@ -585,7 +656,32 @@ This is also configured in broker.xml: -=== Example + Fine grained RBAC on

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-12 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1522138601 ## docs/user-manual/management.adoc: ## @@ -362,6 +366,63 @@ The `*` access is the catch all for everything other method that isn't specifica The

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519879627 ## docs/user-manual/security.adoc: ## @@ -153,9 +161,22 @@ You can do this using the fully qualified queue name (i.e. FQQN) in the `match` -NOTE:

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519877310 ## docs/user-manual/security.adoc: ## @@ -68,6 +68,14 @@ This permission allows the user to browse a queue bound to the matching address. manage:: This

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519811815 ## docs/user-manual/management.adoc: ## @@ -362,6 +366,63 @@ The `*` access is the catch all for everything other method that isn't specifica The

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519799536 ## docs/user-manual/management.adoc: ## @@ -250,8 +251,11 @@ It can be disabled by setting `jmx-management-enabled` to `false` in `broker.xml Role

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519703742 ## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java: ## @@ -463,7 +463,9 @@ private void

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519711041 ## artemis-server/src/test/java/org/apache/activemq/artemis/core/security/RoleTest.java: ## @@ -91,12 +91,12 @@ public void testManageRole() throws Exception {

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519696500 ## artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java: ## @@ -485,7 +473,6 @@ public String

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519679391 ## artemis-core-client/src/main/java/org/apache/activemq/artemis/core/security/Role.java: ## @@ -247,6 +271,12 @@ public String toString() { if (browse)

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519702003 ## artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/config/PersistedSecuritySetting.java: ## @@ -77,7 +83,7 @@ public

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519575016 ## artemis-core-client/src/main/java/org/apache/activemq/artemis/core/security/Role.java: ## @@ -109,6 +115,22 @@ public Role(final String name,

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519567956 ## artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ObjectNameBuilder.java: ## @@ -161,7 +161,7 @@ private String

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519562554 ## artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java: ## @@ -786,7 +786,7 @@ private void

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-11 Thread via GitHub
gtully commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1519556299 ## artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java: ## @@ -337,17 +337,27 @@ private void sendMessage(List

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-07 Thread via GitHub
gemmellr commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1515899178 ## docs/user-manual/management.adoc: ## @@ -362,6 +366,63 @@ The `*` access is the catch all for everything other method that isn't specifica The

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-03-04 Thread via GitHub
gemmellr commented on code in PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#discussion_r1510989284 ## artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java: ## @@ -786,7 +786,7 @@ private void

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-02-29 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1971659697 I think this is good for comments and more eyes. The MBean rbac uses `jmx.` prefixed settings. the Management messages use a suffix on activemq.management to provide the

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-02-26 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1964633266 a question. the object name for an queue, Q1::Q1:

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-02-26 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1964585246 one challenge is keeping things simple, but also this needs to be independent. The VIEW and UPDATE permissions are applicable to both management messages on the

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-02-22 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1959432353 need to work on propagating the new permission into the security control apis, will revert draft when that is complete. -- This is an automated message from the Apache Git

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-02-20 Thread via GitHub
gtully commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1954384492 > Couple of question... > > 1. One of the things that `management.xml` let you do was configure remote JMX connectivity. How do I do that with this? management.xml will

Re: [PR] ARTEMIS-4582 - view and update permissions, for jmx. and activemq.man… [activemq-artemis]

2024-02-19 Thread via GitHub
jbertram commented on PR #4820: URL: https://github.com/apache/activemq-artemis/pull/4820#issuecomment-1953228386 Couple of question... 1. One of the things that `management.xml` let you do was configure remote JMX connectivity. How do I do that with this? 2. One nice thing about