Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-22 Thread via GitHub
jbertram commented on PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823#issuecomment-1959864883 @thezbyg, nice work. Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-22 Thread via GitHub
jbertram merged PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-20 Thread via GitHub
thezbyg commented on code in PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823#discussion_r1496507334 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/MQTTTest.java: ## @@ -447,6 +447,59 @@ public void

Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-20 Thread via GitHub
thezbyg commented on code in PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823#discussion_r1496502532 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/MQTTTest.java: ## @@ -447,6 +447,59 @@ public void

Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-19 Thread via GitHub
jbertram commented on code in PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823#discussion_r1495065245 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/MQTTTest.java: ## @@ -447,6 +447,59 @@ public void

Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-19 Thread via GitHub
jbertram commented on code in PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823#discussion_r1495064960 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/MQTTTest.java: ## @@ -447,6 +447,59 @@ public void

Re: [PR] ARTEMIS-4646 Reuse only acknowledged MQTT IDs [activemq-artemis]

2024-02-19 Thread via GitHub
jbertram commented on code in PR #4823: URL: https://github.com/apache/activemq-artemis/pull/4823#discussion_r1495064560 ## artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSessionState.java: ## @@ -461,8 +459,14 @@ public