[GitHub] [activemq-artemis] MrEasy commented on a change in pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
MrEasy commented on a change in pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r323786778 ## File path: pom.xml ## @@ -90,6 +90,7 @@ 3.6.13.Final 2.4 2.25.0 + 2.1.1 Review comment: Is there a reason not taking the recent version (2.1.2)? (I hope it is not just because in jctool's README on Github 2.1.1 is given) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972823 no worries This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323929755
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,26 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
Review comment:
i would keep byte here, keep the case handling in the order of they are in
JMS and the ordinals.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530996473 The new check for serialized dotnet content type should never be true while the annotation is set to reflect a JMS Object Message, it would be an error if it were. That was the starting point of the discussion, that the client originally did that and should not. Neither the NMS client or any other should set the annotation to that value along with a content type which is other than "application/x-java-serialized-object", so you cant positively check for the dotnet serialized case, only that it is "application/x-java-serialized-object" or that there is none set. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #27: NO-JIRA: Configure continuous integration
Havret commented on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530996289 Added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794 x-opt-jms-msg-type should be honoured, his suggestion was to key on the content type and if java serialized, you return a bytemessage in .net This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794 x-opt-jms-msg-type should be honoured, his suggestion was when msg type =obj then also key on the content type and if java serialized, you return a bytemessage in .net (or you only return obj type, if content type is .net ;), thus then you handle the .net case in .net ;) ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970167 Yes and this is how I've implemented it. Still I am not particularly happy with it. :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972488 thus if no content type (assumed AmqpTypedObject) then return obj, if content type is set, then you only return obj if it was of .net type. returning byte for all other This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972062
what you do is:
if (properties.hasProperty(content type) ) {
if (property.getProperty(content type) == ".net") {
return obj msg
} else {
return byte msg
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972684 very poor but quick pseudo code (sorry) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and do not have neither `application/x-java-serialized-object` nor `application/x-dotnet-serialized-object` content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323926285
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
that way imagine someone made a XMS impl for AMQP where X = some other lang,
then you dont need worry, as you only handle where its positively the
serialized type you can support which is .net varient.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927309
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
```
case MessageSupport.JMS_TYPE_OBJ when HasContentType(message.Properties)):
return GetContentType(message.Properties) == ".NET TYPE" ? new
AmqpNmsObjectMessageFacade() : new AmqpNmsBytesMessageFacade();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage
shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
I believe I've done it, haven't I?
```
case MessageSupport.JMS_TYPE_OBJ:
{
Symbol contentType = GetContentType(message.Properties);
if (IsContentType(SymbolUtil.SERIALIZED_DOTNET_OBJECT_CONTENT_TYPE,
contentType) || contentType == null)
{
return new AmqpNmsObjectMessageFacade();
}
// If the message has different content type defined we should treat it
as bytes message
// as there is a good chance that we cannot deserialize it using .NET
binary deserializer
return new AmqpNmsBytesMessageFacade();
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927309
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
```
case MessageSupport.JMS_TYPE_OBJ when HasContentType(message.Properties)):
return GetContentType(message.Properties) == ".NET TYPE" ? new
AmqpNmsObjectMessageFacade() : new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_OBJ:
return new AmqpNmsObjectMessageFacade();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage
shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
I believe I've done it, haven't I?
```
case MessageSupport.JMS_TYPE_OBJ:
{
Symbol contentType = GetContentType(message.Properties);
if (IsContentType(SymbolUtil.SERIALIZED_DOTNET_OBJECT_CONTENT_TYPE,
contentType) || contentType == null)
{
return new AmqpNmsObjectMessageFacade();
}
// If the message has different content type defined we should treat it
as bytes message
// as there is a good chance that we cannot deserialize it using .NET
binary deserializer
return new AmqpNmsBytesMessageFacade();
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618 so frame tracing should be at TRACE level, it should be expected than you run with this off, and you'd enable change your apps logging level to try debug a more complex issue. It is very verbose, and thus why its at this level. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #28: NO-JIRA: Extend logging
Havret commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160 That's understandable, but I was referring to the @cjwmorgan-sol suggestion to log to this scenario: https://github.com/apache/activemq-nms-amqp/blob/fe657101365e13fb9606962fdc1fcb3160f00116/src/NMS.AMQP/NmsMessageConsumer.cs#L255-L262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160 That's understandable, but I was referring to the @cjwmorgan-sol suggestion to log this scenario: https://github.com/apache/activemq-nms-amqp/blob/fe657101365e13fb9606962fdc1fcb3160f00116/src/NMS.AMQP/NmsMessageConsumer.cs#L255-L262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and have neither `application/x-java-serialized-object` nor `application/x-dotnet-serialized-object` content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bringing back the initial solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration
michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-531002896 @Havret i dont see any update on the readme did you commit it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration
Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#discussion_r323945589 ## File path: README.md ## @@ -1,4 +1,7 @@ # Apache-NMS-AMQP + +[](https://travis-ci.org/apache/activemq-nms-amqp) Review comment: @michaelandrepearce It's here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages, the condition ``` case MessageSupport.JMS_TYPE_OBJ: ``` will never be met for them. Ergo there is no sense in checking content type for .net serializable content type. It won't be there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages the condition ``` case MessageSupport.JMS_TYPE_OBJ: ``` will never be met for them. Ergo there is no sense in checking content type for .net serializable content type. It won't be there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007181 as i said to support NMSObjectMessage (aka .net type) we can simply check content type before bothering with msg types checks. And then we can remove the check in msg type cases , and simply make it that if msgtype is jms-obj and content type is set we return byte msg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #30: AMQNET-611: Apache.NMS.IllegalStateException is throw on transport thread
michaelandrepearce merged pull request #30: AMQNET-611: Apache.NMS.IllegalStateException is throw on transport thread URL: https://github.com/apache/activemq-nms-amqp/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969057 I've pushed the changes that @gemmellr suggested. It should work now. But personally I think this is a bit odd and unnatural to handle a special case for java serialized payload in .NET world. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373 Well you can invert the logic, you return object only if also the .net content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373 Well you can invert the logic, you return object only if also the .net content type. Thus then you are positvely handling .net (and not having a special case for java), would be safe is some other lang started to do the same and sent its own also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971002 Unfortunately I cannot, because it would exclud AmqpTypedObjects which don't have .net content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530978953 You tell me. Does it look better to you? 0f0c557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323925428
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
id inverse this logic, and make it that if it has content type, then
if content type = .net return object else return byte
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928708 ## File path: test/Apache-NMS-AMQP-Test/Provider/Amqp/AmqpCodecTest.cs ## @@ -458,7 +458,6 @@ public void TestNMSMessageEncodingAddsProperMessageAnnotations() DoTestNMSMessageEncodingAddsProperMessageAnnotations(MessageSupport.JMS_TYPE_MAP, null, MessageSupport.JMS_DEST_TYPE_TEMP_QUEUE); DoTestNMSMessageEncodingAddsProperMessageAnnotations(MessageSupport.JMS_TYPE_TXT, MessageSupport.JMS_DEST_TYPE_TOPIC, MessageSupport.JMS_DEST_TYPE_TEMP_QUEUE); DoTestNMSMessageEncodingAddsProperMessageAnnotations(MessageSupport.JMS_TYPE_STRM, MessageSupport.JMS_DEST_TYPE_QUEUE, MessageSupport.JMS_DEST_TYPE_TEMP_QUEUE); - DoTestNMSMessageEncodingAddsProperMessageAnnotations(MessageSupport.JMS_TYPE_OBJ, MessageSupport.JMS_DEST_TYPE_QUEUE, MessageSupport.JMS_DEST_TYPE_TEMP_QUEUE); Review comment: will want a test for the three content type cases, is jms serialized, is .net serialized and none This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928933
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,26 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+return new AmqpNmsBytesMessageFacade();
+case MessageSupport.JMS_TYPE_OBJ:
+{
+Symbol contentType =
GetContentType(message.Properties);
+if
(IsContentType(SymbolUtil.SERIALIZED_DOTNET_OBJECT_CONTENT_TYPE, contentType)
|| contentType == null)
Review comment:
Can we remove the Serialized_java_object_content_type static in SymbolUtil
now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration
michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530990560 Do we have link to the CI build, e.g. have we added a badge to the readme for master build? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration
michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530990560 Do we have link to the CI build, e.g. have we added a badge to the readme? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemmellr Am I correct? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemme This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage
shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928453
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
I believe I've done it, haven't I?
```
case MessageSupport.JMS_TYPE_OBJ:
{
Symbol contentType = GetContentType(message.Properties);
if (IsContentType(SymbolUtil.SERIALIZED_DOTNET_OBJECT_CONTENT_TYPE,
contentType) || contentType == null)
{
return new AmqpNmsObjectMessageFacade();
}
// If the message has different content type defined we should treat it
as bytes message
// as there is a good chance that we cannot deserialize it using .NET
binary deserializer
return new AmqpNmsBytesMessageFacade();
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928092
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,26 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+return new AmqpNmsBytesMessageFacade();
+case MessageSupport.JMS_TYPE_OBJ:
+{
+Symbol contentType =
GetContentType(message.Properties);
+if
(IsContentType(SymbolUtil.SERIALIZED_DOTNET_OBJECT_CONTENT_TYPE, contentType)
|| contentType == null)
+{
+return new AmqpNmsObjectMessageFacade();
+}
+
+// If the message has different content type defined
we should treat it as bytes message
+// as there is a good chance that we cannot
deserialize it using .NET binary deserializer
+return new AmqpNmsBytesMessageFacade();
Review comment:
Yup :) +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging
michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618 so frame tracing should be at TRACE level, it should be expected than you run with this off, and you'd enable change your apps logging level to try debug a more complex issue. It is very verbose, and thus why its at this level. (and why its called frame "tracing") This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration
michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530990560 Do we have link to the CI build, have we added a badge to the readme? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bring back the initial solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration
Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#discussion_r323945589 ## File path: README.md ## @@ -1,4 +1,7 @@ # Apache-NMS-AMQP + +[](https://travis-ci.org/apache/activemq-nms-amqp) Review comment: It's here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323945364
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
-case MessageSupport.JMS_TYPE_BYTE:
-return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
-case MessageSupport.JMS_TYPE_OBJ:
-return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+case MessageSupport.JMS_TYPE_BYTE:
+// Java serialized objects should be treated as bytes
messages
+// as we cannot deserialize them in .NET world
+case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
yes, i think we were overlapping, current looked good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005976 If the JMS Message type annotation is set, to say it is a JMS ObjectMessage compatible message, then thecontent type is "application/x-java-serialized-object", or it is not set (non serialized payload). My original comment is merely saying to remove the check that the annotation is set, and the content type is 'serialized dotnet' as it cant be true. It is not a JMS Object Message compatible message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790 right, so what we can do then, is first check content type, if content type = application/x-net-serialized-object then its object message, else then we check the msg type. and then when msg-type = jms obj we only return object if no content type (aka the Amqp varient) else we return byte msg for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790 right, so what we can do then, is first check content type, (before any of the switching) if content type = application/x-net-serialized-object then its object message, else then we check the msg type. and then when msg-type = jms obj we only return object if no content type (aka the Amqp varient) else we return byte msg for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531008470 Bingo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
