[GitHub] [activemq-artemis] wy96f edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
wy96f edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547231728 I was dubious about it too, but after some analysis, I somewhat understood it. In fact size estimator is limiting non file packets in file region=true. The log showed flow control triggered every ~450 times send. This make senses as each non file packet occupies ~300 bytes, and total size of them just over highWaterMark(default 128k). And flow control waited for ~4 seconds to allow 450 non file and 450 file packet to be drained(~450*1MB chunk size=~450MB data transferred in ~4 seconds, i.e. ~100MB/s). I uploaded a file containing a small section of artemis.log, see https://filebin.net/emt7r3h7yg30zq8e/artemis_section.log?t=r9f67qpl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
wy96f commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547231728 I was dubious about it too, but after some analysis, I somewhat understood it. In fact size estimator is limiting non file packets in file region=true. The log showed flow control triggered every ~450 times send. This make senses as each non file packet occupies ~300 bytes, and total size of them just over highWaterMark(default 128k). And flow control waited for ~4 seconds to allow 450 non file and 450 file packet to be drained(~450*1MB chunk size=~450MB data transferred in ~4 seconds, i.e. ~100MB/s). That's being said, I uploaded a file containing a small section of artemis.log, see https://filebin.net/emt7r3h7yg30zq8e/artemis_section.log?t=r9f67qpl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame
Havret commented on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547092058 @cjwmorgan-sol Could you please take a look at this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547052727 @wy96f One quick question: on https://github.com/apache/activemq-artemis/pull/2845#issuecomment-535440070 I see that you've said: > with -Dio.netty.file.region=true or master But actually master and `-Dio.netty.file.region=true` are very different! master has the feature with zero copy not enabled and `ByteBuf` are correctly estimated, while `-Dio.netty.file.region=true` on this PR is using custom `FileRegion`s that doesn't seems correctly estimated according to https://github.com/netty/netty/blob/ff7a9fa091a8bf2e10020f83fc4df1c44098/transport/src/main/java/io/netty/channel/DefaultMessageSizeEstimator.java#L45. In theory `-Dio.netty.file.region=true` should time out due to the wrong estimation (like `-Dio.netty.file.region=false`): do you have tested `-Dio.netty.file.region=true` on this PR with your long replication backlog test? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547052727 @wy96f One quick question: on https://github.com/apache/activemq-artemis/pull/2845#issuecomment-535440070 I see that you've said: > with -Dio.netty.file.region=true or master But actually master and `-Dio.netty.file.region=true` are very different! master has the feature with zero copy not enabled and `ByteBuf` are correctly estimated, while `-Dio.netty.file.region=true` on this PR is using custom `FileRegion`s that doesn't seems correctly estimated according to https://github.com/netty/netty/blob/ff7a9fa091a8bf2e10020f83fc4df1c44098/transport/src/main/java/io/netty/channel/DefaultMessageSizeEstimator.java#L45. In theory `-Dio.netty.file.region=true` should time out due to the wrong estimation: do you have tested `-Dio.netty.file.region=true` on this PR with your long replication backlog test? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match
jbertram commented on a change in pull request #2851: ARTEMIS-2503 Improve
wildcards for the roles access match
URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r339662189
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/JMXAccessControlList.java
##
@@ -25,12 +25,22 @@
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.apache.activemq.artemis.core.settings.HierarchicalRepository;
+import
org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository;
+
public class JMXAccessControlList {
private Access defaultAccess = new Access("*");
- private Map domainAccess = new HashMap<>();
+ private HierarchicalRepository domainAccess;
private ConcurrentHashMap> whitelist = new
ConcurrentHashMap<>();
+ public JMXAccessControlList() {
+ WildcardConfiguration domainAccessWildcardConfiguration = new
WildcardConfiguration();
Review comment:
@brusdev, that makes sense. I think something needs to be added to the docs
explaining this otherwise the behavior might catch users by surprise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2850: ARTEMIS-2504 implement retroactive addresses
asfgit closed pull request #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC opened a new pull request #46: AMQNET-623: Error logged during connection close when broker is down
HavretGC opened a new pull request #46: AMQNET-623: Error logged during connection close when broker is down URL: https://github.com/apache/activemq-nms-amqp/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC opened a new pull request #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame
HavretGC opened a new pull request #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup
asfgit merged pull request #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup URL: https://github.com/apache/activemq-artemis/pull/2872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup
asfgit merged pull request #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup URL: https://github.com/apache/activemq-artemis/pull/2872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
