[GitHub] [activemq] jbonofre merged pull request #403: [AMQ-7330] Upgrade to Jetty 9.4.22.v20191022
jbonofre merged pull request #403: [AMQ-7330] Upgrade to Jetty 9.4.22.v20191022 URL: https://github.com/apache/activemq/pull/403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre opened a new pull request #404: [AMQ-7324] Upgrade to commons-dbcp2 2.7.0 and commons-pool2 2.7.0
jbonofre opened a new pull request #404: [AMQ-7324] Upgrade to commons-dbcp2 2.7.0 and commons-pool2 2.7.0 URL: https://github.com/apache/activemq/pull/404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-548529114 @wy96f I've tried to understand what's happening for ChunkedNioFile and probably it needs to be fixed Netty-side (see https://github.com/netty/netty/issues/3413#issuecomment-548501688), let's see. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2868: ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO
brusdev commented on a change in pull request #2868: ARTEMIS-2466
PageSyncTimer::timeSync isn't configurable using ASYNCIO
URL: https://github.com/apache/activemq-artemis/pull/2868#discussion_r341210052
##
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
##
@@ -1002,43 +1003,51 @@ private void applyAddressesAndQueues(HashMap filters) {
private void performAutoTune(HashMap filters, JournalType
journalType, File dataFolder) {
if (noAutoTune) {
filters.put("${journal-buffer.settings}", "");
+ filters.put("${page-sync.settings}", "");
} else {
try {
int writes = 250;
System.out.println("");
System.out.println("Auto tuning journal ...");
+long time = SyncCalculation.syncTest(dataFolder, 4096, writes, 5,
verbose, !noJournalSync, false, "journal-test.tmp",
ActiveMQDefaultConfiguration.getDefaultJournalMaxIoAio(), journalType);
+long nanoseconds = SyncCalculation.toNanos(time, writes, verbose);
+double writesPerMillisecond = (double) writes / (double) time;
+String writesPerMillisecondStr = new
DecimalFormat("###.##").format(writesPerMillisecond);
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram opened a new pull request #2880: NO-JIRA checkstyle upgrade
jbertram opened a new pull request #2880: NO-JIRA checkstyle upgrade URL: https://github.com/apache/activemq-artemis/pull/2880 This replaces #2875 which was insufficient to deal with the issues related to the actual checkstyle upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram closed pull request #2875: Bump checkstyle from 7.7 to 8.18
jbertram closed pull request #2875: Bump checkstyle from 7.7 to 8.18 URL: https://github.com/apache/activemq-artemis/pull/2875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] dependabot[bot] commented on issue #2875: Bump checkstyle from 7.7 to 8.18
dependabot[bot] commented on issue #2875: Bump checkstyle from 7.7 to 8.18 URL: https://github.com/apache/activemq-artemis/pull/2875#issuecomment-548400441 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule
jbertram commented on issue #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule URL: https://github.com/apache/activemq-artemis/pull/2879#issuecomment-548371073 Merged it. Nice work, and thanks for the contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule
asfgit merged pull request #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule URL: https://github.com/apache/activemq-artemis/pull/2879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule
asfgit merged pull request #2879: ARTEMIS-2535 Add ignorePartialResultException option to LDAPLoginModule URL: https://github.com/apache/activemq-artemis/pull/2879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre opened a new pull request #403: [AMQ-7330] Upgrade to Jetty 9.4.22.v20191022
jbonofre opened a new pull request #403: [AMQ-7330] Upgrade to Jetty 9.4.22.v20191022 URL: https://github.com/apache/activemq/pull/403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548296114 Great! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548295969 I'm not arguing either way, just saying it needs discussed first, given its happening well after a release was proposed. I would say supporting 9+ doesn't necessarily need to mean dropping 8, unless folks want to. Obviously Derby have done that though, so clearly folks are starting to do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548295806 @gemmellr just started the discussion on the mailing list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548293890 @gemmellr agree, I will start a thread on the mailing list about 5.16.0 minimum Java version. My understanding is to fully support Java 9+, but let's double check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548293028 I know its on master but to me the branch isnt that important, still seems like a discuss-before-commit type of change, especially if a release from the branch was already proposed to happen. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548292132 But agree to be discussed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
gemmellr commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548291290 Derby 10.15.1.3 requires Java 9 to run. Changing the minimum JDK requirements to 9+ seems like it would be a discussion topic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre removed a comment on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre removed a comment on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548288736 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548288736 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre commented on issue #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402#issuecomment-548236980 `EmbeddedDataSource` needs an update. I'm fixing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre opened a new pull request #402: [AMQ-7325] Upgrade to Derby 10.15.1.3
jbonofre opened a new pull request #402: [AMQ-7325] Upgrade to Derby 10.15.1.3 URL: https://github.com/apache/activemq/pull/402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
