[GitHub] [activemq] coheigea opened a new pull request #409: Update owasp plugin (and enable it to run correctly)
coheigea opened a new pull request #409: Update owasp plugin (and enable it to run correctly) URL: https://github.com/apache/activemq/pull/409 Currently, the owasp plugin doesn't run correctly due to some system scope failures. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM
clebertsuconic edited a comment on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM URL: https://github.com/apache/activemq-artemis/pull/2881#issuecomment-549380980 there was no other semantic changes here beyong removing synchronized? i'm confused on whatyou changed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM
clebertsuconic edited a comment on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM URL: https://github.com/apache/activemq-artemis/pull/2881#issuecomment-549380980 there was no other semantic changes here beyong removing synchronized? i'm confused on what you changed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM
clebertsuconic commented on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM URL: https://github.com/apache/activemq-artemis/pull/2881#issuecomment-549380980 there was no other semantic changes here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM
clebertsuconic commented on issue #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM URL: https://github.com/apache/activemq-artemis/pull/2881#issuecomment-549380631 No test possible? I understand it's not possible to write a test that would run for 10 minutes... but is there anything that can at least exercise more than one batch on the tx.commit() while removing? We wouldn't be testing for the OME as that''s not feasible here.. but at least making sure the semantic works as expected? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-549300079 @wy96f I've added an additional commit to control the backlog of unflushed Netty writes, to improve the precision of the initial replication timeout performed right after "sending" all the replicated files: due to how Netty works (the previous comment has the relevant info about it), probably is the safer way to fail fast due to slow network/dead connections on replication. Let me know if your test won't be too slow due to this (with both zero copy or not) and if it seems correct now (without changing the default timeout on initial replication). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-549300079 @wy96f I've added an additional commit to control the backlog of unflushed Netty writes, to improve the precision of the replication done timeout performed right after "sending" all the replicated files: due to how Netty works (the previous comment has the relevant info about it), probably is the safer way to fail fast due to slow network/dead connections on replication. Let me know if your test won't be too slow due to this (with both zero copy or not) and if it seems correct now (without changing the default timeout on initial replication). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] brusdev opened a new pull request #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM
brusdev opened a new pull request #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM URL: https://github.com/apache/activemq-artemis/pull/2881 The iterQueue transaction commits are locked by the synchronization context. So removing all messages from a huge queue causes the creation of too locked transactions for the paged messages and so OOM. The iteration on paged message is executed out the iterQueue synchronization context to avoid to lock the transaction commits. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
