[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-550951027 @clebertsuconic I believe this is getting in good shape for a review, according to the test results. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f opened a new pull request #2885: ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory
wy96f opened a new pull request #2885: ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory URL: https://github.com/apache/activemq-artemis/pull/2885 If page transaction is rolled back, it will reside in transactions map unless broker restarts. Remove it when messages in the transaction are all acked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on a change in pull request #410: [AMQ-7327] Use maxFrameSize to limit HTTP content length
jbonofre commented on a change in pull request #410: [AMQ-7327] Use
maxFrameSize to limit HTTP content length
URL: https://github.com/apache/activemq/pull/410#discussion_r343182748
##
File path:
activemq-http/src/test/java/org/apache/activemq/transport/http/HttpMaxFrameSizeTest.java
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.transport.http;
+
+import org.apache.activemq.ActiveMQConnectionFactory;
+import org.apache.activemq.broker.BrokerService;
+import org.apache.activemq.command.ActiveMQQueue;
+import org.apache.commons.lang.StringUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.jms.Connection;
+import javax.jms.JMSException;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+
+public class HttpMaxFrameSizeTest {
+
+protected BrokerService brokerService;
+
+@Before
+public void setup() throws Exception {
+brokerService = new BrokerService();
+brokerService.setPersistent(false);
+brokerService.setUseJmx(false);
+brokerService.deleteAllMessages();
+
brokerService.addConnector("http://localhost:?wireFormat.maxFrameSize=10;);
+brokerService.start();
+brokerService.waitUntilStarted();
+}
+
+@After
+public void teardown() throws Exception {
+brokerService.stop();
+}
+
+@Test(expected = JMSException.class)
Review comment:
@tabish121 updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2871: NO-JIRA improve transformer docs
asfgit closed pull request #2871: NO-JIRA improve transformer docs URL: https://github.com/apache/activemq-artemis/pull/2871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2884: NO-JIRA Fix indention in browse.js
asfgit merged pull request #2884: NO-JIRA Fix indention in browse.js URL: https://github.com/apache/activemq-artemis/pull/2884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2884: NO-JIRA Fix indention in browse.js
asfgit merged pull request #2884: NO-JIRA Fix indention in browse.js URL: https://github.com/apache/activemq-artemis/pull/2884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on a change in pull request #410: [AMQ-7327] Use maxFrameSize to limit HTTP content length
jbonofre commented on a change in pull request #410: [AMQ-7327] Use
maxFrameSize to limit HTTP content length
URL: https://github.com/apache/activemq/pull/410#discussion_r343113819
##
File path:
activemq-http/src/test/java/org/apache/activemq/transport/http/HttpMaxFrameSizeTest.java
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.transport.http;
+
+import org.apache.activemq.ActiveMQConnectionFactory;
+import org.apache.activemq.broker.BrokerService;
+import org.apache.activemq.command.ActiveMQQueue;
+import org.apache.commons.lang.StringUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.jms.Connection;
+import javax.jms.JMSException;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+
+public class HttpMaxFrameSizeTest {
+
+protected BrokerService brokerService;
+
+@Before
+public void setup() throws Exception {
+brokerService = new BrokerService();
+brokerService.setPersistent(false);
+brokerService.setUseJmx(false);
+brokerService.deleteAllMessages();
+
brokerService.addConnector("http://localhost:?wireFormat.maxFrameSize=10;);
+brokerService.start();
+brokerService.waitUntilStarted();
+}
+
+@After
+public void teardown() throws Exception {
+brokerService.stop();
+}
+
+@Test(expected = JMSException.class)
Review comment:
@tabish121 thanks Tim, you are right, let me improve a bit the test coverage
;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] tabish121 commented on a change in pull request #410: [AMQ-7327] Use maxFrameSize to limit HTTP content length
tabish121 commented on a change in pull request #410: [AMQ-7327] Use
maxFrameSize to limit HTTP content length
URL: https://github.com/apache/activemq/pull/410#discussion_r343112507
##
File path:
activemq-http/src/test/java/org/apache/activemq/transport/http/HttpMaxFrameSizeTest.java
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.transport.http;
+
+import org.apache.activemq.ActiveMQConnectionFactory;
+import org.apache.activemq.broker.BrokerService;
+import org.apache.activemq.command.ActiveMQQueue;
+import org.apache.commons.lang.StringUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.jms.Connection;
+import javax.jms.JMSException;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+
+public class HttpMaxFrameSizeTest {
+
+protected BrokerService brokerService;
+
+@Before
+public void setup() throws Exception {
+brokerService = new BrokerService();
+brokerService.setPersistent(false);
+brokerService.setUseJmx(false);
+brokerService.deleteAllMessages();
+
brokerService.addConnector("http://localhost:?wireFormat.maxFrameSize=10;);
+brokerService.start();
+brokerService.waitUntilStarted();
+}
+
+@After
+public void teardown() throws Exception {
+brokerService.stop();
+}
+
+@Test(expected = JMSException.class)
Review comment:
Expecting an JMSException on a test that calls many methods that can throw a
JMSException doesn't actually test that the change does what you are expecting
it to. The producer send should be the point of test here so that you confirm
that it does indeed fail when to large, but also you need some negative
validation (send a smaller message) to test that your configuration doesn't get
mistakenly applied to smaller messages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] jbonofre merged pull request #409: Update owasp plugin (and enable it to run correctly)
jbonofre merged pull request #409: Update owasp plugin (and enable it to run correctly) URL: https://github.com/apache/activemq/pull/409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] sebthom commented on issue #2884: NO-JIRA Fix indention in browser.js
sebthom commented on issue #2884: NO-JIRA Fix indention in browser.js URL: https://github.com/apache/activemq-artemis/pull/2884#issuecomment-550297174 The github diff mechanism apparently isn't very intelligent, you can use this link https://github.com/apache/activemq-artemis/pull/2884/files?w=1 to see that no functional changes were applied. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] sebthom opened a new pull request #2884: NO-JIRA Fix indention in browser.js
sebthom opened a new pull request #2884: NO-JIRA Fix indention in browser.js URL: https://github.com/apache/activemq-artemis/pull/2884 This only changes the formatting, no functional changes. This will make it easier to review future functional changes of the file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
wy96f commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-550260676 @franz1981 I tested with my load generator. The pr worked fine and showed no sign of slowing :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre opened a new pull request #410: [AMQ-7327] Use maxFrameSize to limit HTTP content length
jbonofre opened a new pull request #410: [AMQ-7327] Use maxFrameSize to limit HTTP content length URL: https://github.com/apache/activemq/pull/410 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
