[GitHub] [activemq] coheigea opened a new pull request #429: AMQ-7231 - Fix XSS in WebConsole
coheigea opened a new pull request #429: AMQ-7231 - Fix XSS in WebConsole URL: https://github.com/apache/activemq/pull/429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2951: Artemis-2563 Add option to create queue on all active clustered nodes
clebertsuconic commented on issue #2951: Artemis-2563 Add option to create queue on all active clustered nodes URL: https://github.com/apache/activemq-artemis/pull/2951#issuecomment-578219712 - I have not seen any tests added on your PR - we should have a discussion about the feature itself.. as it may be extremely dangerous. I would prefer having a single subscription on a single node, and clients connecting to that node. - The PR as it stands it can't be merged.. lack of tests.. you actually are breaking compatibility on the compatility testsuite... (the PR is probably failing because of that). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] brusdev opened a new pull request #2953: ARTEMIS-2600 Update mqtt-client version to 1.16 for tests
brusdev opened a new pull request #2953: ARTEMIS-2600 Update mqtt-client version to 1.16 for tests URL: https://github.com/apache/activemq-artemis/pull/2953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match
brusdev commented on a change in pull request #2851: ARTEMIS-2503 Improve
wildcards for the roles access match
URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r370603131
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/JMXAccessControlList.java
##
@@ -25,12 +25,22 @@
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.apache.activemq.artemis.core.settings.HierarchicalRepository;
+import
org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository;
+
public class JMXAccessControlList {
private Access defaultAccess = new Access("*");
- private Map domainAccess = new HashMap<>();
+ private HierarchicalRepository domainAccess;
private ConcurrentHashMap> whitelist = new
ConcurrentHashMap<>();
+ public JMXAccessControlList() {
+ WildcardConfiguration domainAccessWildcardConfiguration = new
WildcardConfiguration();
Review comment:
@jbertram I missed your last comment. I created the new PR #2952 to improve
the doc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev opened a new pull request #2952: NO-JIRA improve role-access match priority doc
brusdev opened a new pull request #2952: NO-JIRA improve role-access match priority doc URL: https://github.com/apache/activemq-artemis/pull/2952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] HavretGC commented on issue #12: NMS 2.0 WIP
HavretGC commented on issue #12: NMS 2.0 WIP URL: https://github.com/apache/activemq-nms-api/pull/12#issuecomment-578047073 Quite a lot of new APIs, I will take a look over the weekend. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] HavretGC edited a comment on issue #12: NMS 2.0 WIP
HavretGC edited a comment on issue #12: NMS 2.0 WIP URL: https://github.com/apache/activemq-nms-api/pull/12#issuecomment-578047073 Quite a lot of new APIs, I will take a look at it over the weekend. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
