michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531356195
@gemmellr i think were all agreed now, but could you just give a +1 that
your happy with the change before i
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007181
as i said to support NMSObjectMessage (aka .net type) we can simply check
content type before bothering with
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790
right, so what we can do then, is first check content type,
if
content type = application/x-net-seriali
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531003774
@gemmellr why cant .net have its own content type? theres no restriction on
content type can be set to.
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530978350
Made sense?
This is an automated message fro
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972684
very poor but quick pseudo code (sorry)
This
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972488
thus if no content type (assumed AmqpTypedObject) then return obj, if
content type is set, then you only retu
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972062
what you do is:
if (properties.hasProperty(content type) ) {
if (property.getProperty(content t
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971166
why would it exclude those?
This is an autom
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373
Well you can invert the logic, you return object only if also the .net
content type.
---
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794
x-opt-jms-msg-type should be honoured, his suggestion was to key on the
content type and if java serialized,
11 matches
Mail list logo