[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #42: AMQNET-619: Handle remote detach properly for sender link

2019-10-05 Thread GitBox 
Havret commented on a change in pull request #42: AMQNET-619: Handle remote 
detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331738433
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
 
 Review comment:
   Hope it's ok now.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #42: AMQNET-619: Handle remote detach properly for sender link

2019-10-04 Thread GitBox 
Havret commented on a change in pull request #42: AMQNET-619: Handle remote 
detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331732826
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+var tsc = new TaskCompletionSource();
 
 Review comment:
   Sure thing. Fixed. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services