[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages the condition ``` case

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`.

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bring back the initial solution.

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530978953 You tell me. Does it look better to you? 0f0c557 This

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972823 no worries This is an automated message from the Apache

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971002 Unfortunately I cannot, because it would exclud AmqpTypedObjects which don't have .net content type.

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970167 Yes and this is how I've implemented it. Still I am not particularly happy with it. :(