[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages, the condition ``` case

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemmellr Am

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemme

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bringing back the initial solution. --

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and have neither `application/x-java-serialized-object` nor `a

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and do not have neither `application/x-java-serialized-object`

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969057 I've pushed the changes that @gemmellr suggested. It should work now. But personally I think this is a bit odd and