[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages, the condition ``` case MessageSupport.JMS_TYPE_OBJ: ``` will never be met for them. Ergo there is no sense in checking content type for .net serializable content type. It won't be there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemmellr Am I correct? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemme This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bringing back the initial solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and have neither `application/x-java-serialized-object` nor `application/x-dotnet-serialized-object` content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and do not have neither `application/x-java-serialized-object` nor `application/x-dotnet-serialized-object` content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969057 I've pushed the changes that @gemmellr suggested. It should work now. But personally I think this is a bit odd and unnatural to handle a special case for java serialized payload in .NET world. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services