[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging

2019-09-22 Thread GitBox
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533918205 Jira item needed. Also squash commits pls This is an automated message from the

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging

2019-09-14 Thread GitBox
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-531537811 @cjwmorgan-sol the point here is the exception would be from user code the provided listener. Users have opportunity to catch and log them selve

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging

2019-09-13 Thread GitBox
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-531367659 Why would we log here? Exception here would be because exception was thrown within users message listener code. I would expect if it was importa

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618 so frame tracing should be at TRACE level, it should be expected than you run with this off, and you'd enable change your apps logging level to