[GitHub] [hive] GuoPhilipse commented on pull request #1359: HIVE-23988: Remove unused method

GuoPhilipse commented on pull request #1359: URL: https://github.com/apache/hive/pull/1359#issuecomment-668991467 @jcamachor Could you help review ? Please kindly corrected me if i miss sth. Thanks in advance. This is an

[GitHub] [hive] jcamachor commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

jcamachor commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r465446495 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java ## @@ -92,7 +104,7 @@ public void

[GitHub] [hive] jcamachor commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

jcamachor commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r465446298 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAntiSemiJoinRule.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

jcamachor commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465443070 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache

[GitHub] [hive] viirya commented on a change in pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on a change in pull request #1356: URL: https://github.com/apache/hive/pull/1356#discussion_r465395633 ## File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java ## @@ -207,11 +207,11 @@ public Long getDuration(String method) { } -

[GitHub] [hive] mustafaiman commented on a change in pull request #1337: HIVE-23952: Reuse VectorAggregationBuffer to reduce GC pressure in VectorGroupByOperator

mustafaiman commented on a change in pull request #1337: URL: https://github.com/apache/hive/pull/1337#discussion_r465387373 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java ## @@ -21,6 +21,10 @@ import static

[GitHub] [hive] rbalamohan commented on a change in pull request #1337: HIVE-23952: Reuse VectorAggregationBuffer to reduce GC pressure in VectorGroupByOperator

rbalamohan commented on a change in pull request #1337: URL: https://github.com/apache/hive/pull/1337#discussion_r465386334 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java ## @@ -21,6 +21,10 @@ import static

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465362372 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465356752 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1619,6 +1620,9 @@ public static ColStatistics

[GitHub] [hive] saihemanth-cloudera opened a new pull request #1361: Exception type chhanged to TException for TestListPartitions#testList…

saihemanth-cloudera opened a new pull request #1361: URL: https://github.com/apache/hive/pull/1361 …PartitionSpecsNullTblName+testListPartitionValuesEmptySchema ### What changes were proposed in this pull request? ### Why are the changes needed?

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r465349679 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r465297563 ## File path: ql/src/test/queries/clientpositive/subquery_in_having.q ## @@ -140,6 +140,22 @@ CREATE TABLE src_null_n4 (key STRING COMMENT 'default',

[GitHub] [hive] sumeetgajjar opened a new pull request #1360: HIVE-23989: Read isMetastoreRemote flag from system var in StartMiniS2Cluster

sumeetgajjar opened a new pull request #1360: URL: https://github.com/apache/hive/pull/1360 ### What changes were proposed in this pull request? Read isMetastoreRemote flag from system var when running testRunCluster test in StartMiniS2Cluster.java ###

[GitHub] [hive] risdenk commented on pull request #1342: HIVE-23958: HiveServer2 should support additional keystore/truststore types besides JKS

risdenk commented on pull request #1342: URL: https://github.com/apache/hive/pull/1342#issuecomment-668775601 Rebased to kick off new set of tests. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] jcamachor commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

jcamachor commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r465213541 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r465207659 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r465206179 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] jcamachor commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

jcamachor commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r465197102 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] jcamachor commented on a change in pull request #1357: HIVE-23963: UnsupportedOperationException in queries 74 and 84 while applying HiveCardinalityPreservingJoinRule

jcamachor commented on a change in pull request #1357: URL: https://github.com/apache/hive/pull/1357#discussion_r465194632 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelDistribution.java ## @@ -82,7 +83,14 @@ public RelDistribution

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1347: HIVE-23965: Improve plan regression tests using TPCDS30TB metastore dump and custom configs

kgyrtkirk commented on a change in pull request #1347: URL: https://github.com/apache/hive/pull/1347#discussion_r465151500 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java ## @@ -405,4 +409,11 @@ private String

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r465192529 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] belugabehr closed pull request #1241: HIVE-22415: Upgrade to Java 11

belugabehr closed pull request #1241: URL: https://github.com/apache/hive/pull/1241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] GuoPhilipse opened a new pull request #1359: HIVE-23988: Remove unused method

GuoPhilipse opened a new pull request #1359: URL: https://github.com/apache/hive/pull/1359 ### What changes were proposed in this pull request? remove unused method in FunctionRegistry.java ### Why are the changes needed? improve hive code quality ### Does this PR

[GitHub] [hive] kgyrtkirk commented on pull request #1341: HIVE-23959: Provide an option to wipe out column stats for partitioned tables in case of column removal

kgyrtkirk commented on pull request #1341: URL: https://github.com/apache/hive/pull/1341#issuecomment-668638141 @pvary could you please take another look? This is an automated message from the Apache Git Service. To respond

[GitHub] [hive] klcopp closed pull request #1346: HIVE-23966: Minor query-based compaction always results in delta dirs with minWriteId=1

klcopp closed pull request #1346: URL: https://github.com/apache/hive/pull/1346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] nrg4878 commented on pull request #1221: HIVE-23786: HMS server side filter with Ranger

nrg4878 commented on pull request #1221: URL: https://github.com/apache/hive/pull/1221#issuecomment-668587992 Fix has been merged into master. Thanks for the patch @sam-an-cloudera This is an automated message from the

[GitHub] [hive] szlta merged pull request #1332: HIVE-23947

szlta merged pull request #1332: URL: https://github.com/apache/hive/pull/1332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] maheshk114 merged pull request #1340: HIVE-23953 : Use task counter information to compute keycount during hashtable loading

maheshk114 merged pull request #1340: URL: https://github.com/apache/hive/pull/1340 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] aasha opened a new pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

aasha opened a new pull request #1358: URL: https://github.com/apache/hive/pull/1358 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] klcopp commented on pull request #1346: HIVE-23966: Minor query-based compaction always results in delta dirs with minWriteId=1

klcopp commented on pull request #1346: URL: https://github.com/apache/hive/pull/1346#issuecomment-668523554 Closed and reopened so tests would run; they should pass now that HIVE-23763 is in This is an automated message

[GitHub] [hive] klcopp closed pull request #1346: HIVE-23966: Minor query-based compaction always results in delta dirs with minWriteId=1

klcopp closed pull request #1346: URL: https://github.com/apache/hive/pull/1346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] kuczoram merged pull request #1327: HIVE-23763: Query based minor compaction produces wrong files when ro…

kuczoram merged pull request #1327: URL: https://github.com/apache/hive/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] pvary merged pull request #1309: HIVE-23929: Run compaction as partition owner

pvary merged pull request #1309: URL: https://github.com/apache/hive/pull/1309 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] pvary commented on pull request #1307: HIVE-23896:Improve code quality, ASTErrorUtils.getMessage Method requires only two parameters

pvary commented on pull request #1307: URL: https://github.com/apache/hive/pull/1307#issuecomment-668504712 @dh20 Green run is needed for pushing the changes. Please retrigger :( This is an automated message from the Apache

[GitHub] [hive] dh20 edited a comment on pull request #1307: HIVE-23896:Improve code quality, ASTErrorUtils.getMessage Method requires only two parameters

dh20 edited a comment on pull request #1307: URL: https://github.com/apache/hive/pull/1307#issuecomment-667814466 @pvary These errors are not caused by my changes. Can you help me to have a look? Thank you very much This

[GitHub] [hive] pkumarsinha commented on a change in pull request #1345: HIVE-23961 : Enable external table replication by default

pkumarsinha commented on a change in pull request #1345: URL: https://github.com/apache/hive/pull/1345#discussion_r464868111 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ## @@ -564,7 +564,7 @@ private static void populateLlapDaemonVarsSet(Set

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464859899 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1641,28 +1645,26 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1341: HIVE-23959: Provide an option to wipe out column stats for partitioned tables in case of column removal

pvary commented on a change in pull request #1341: URL: https://github.com/apache/hive/pull/1341#discussion_r464851008 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java ## @@ -2960,4 +2976,21 @@ public

[GitHub] [hive] pvary commented on a change in pull request #1341: HIVE-23959: Provide an option to wipe out column stats for partitioned tables in case of column removal

pvary commented on a change in pull request #1341: URL: https://github.com/apache/hive/pull/1341#discussion_r464851008 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java ## @@ -2960,4 +2976,21 @@ public

[GitHub] [hive] rbalamohan commented on pull request #1340: HIVE-23953 : Use task counter information to compute keycount during hashtable loading

rbalamohan commented on pull request #1340: URL: https://github.com/apache/hive/pull/1340#issuecomment-668426658 LGTM. +1 pending tests. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hive] pvary merged pull request #1230: HIVE-23819: Use ranges in ValidReadTxnList serialization

pvary merged pull request #1230: URL: https://github.com/apache/hive/pull/1230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] kasakrisz opened a new pull request #1357: HIVE-23963: UnsupportedOperationException in queries 74 and 84 while applying HiveCardinalityPreservingJoinRule

kasakrisz opened a new pull request #1357: URL: https://github.com/apache/hive/pull/1357 ### What changes were proposed in this pull request? Avoid `UnsupportedOperationException` when calculating cost using `HiveOnTezCostModel`.