[PR] HIVE-28090: Correct desc of `hive.metastore.disallow.incompatible.col.type.changes` of `HiveConf.java` [hive]

2024-02-23 Thread via GitHub
ming95 opened a new pull request, #5097: URL: https://github.com/apache/hive/pull/5097 ### What changes were proposed in this pull request? correct desc of `hive.metastore.disallow.incompatible.col.type.changes`, In fact the default value is true. ### Why are t

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501361266 ## llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LocalDirCleaner.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed under the Apache License, Version 2.0 (the

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501361100 ## llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LocalDirCleaner.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed under the Apache License, Version 2.0 (the

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501361157 ## llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LocalDirCleaner.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed under the Apache License, Version 2.0 (the

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501360964 ## llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LocalDirCleaner.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed under the Apache License, Version 2.0 (the

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501360812 ## llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemon.java: ## @@ -83,26 +95,67 @@ public void tearDown() { for (String mSource : METRICS

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501360630 ## llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LocalDirCleaner.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed under the Apache License, Version 2.0 (the

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-02-23 Thread via GitHub
abstractdog commented on code in PR #5054: URL: https://github.com/apache/hive/pull/5054#discussion_r1501359175 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -5508,6 +5508,17 @@ public static enum ConfVars { LLAP_TASK_TIME_SUMMARY( "hive.llap.

Re: [PR] HIVE-28083: Enable HMS client cache and HMS query cache for Explain p… [hive]

2024-02-23 Thread via GitHub
sonarcloud[bot] commented on PR #5092: URL: https://github.com/apache/hive/pull/5092#issuecomment-1962078023 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28083: Enable HMS client cache and HMS query cache for Explain p… [hive]

2024-02-23 Thread via GitHub
soumyakanti3578 commented on code in PR #5092: URL: https://github.com/apache/hive/pull/5092#discussion_r1501168235 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreClientWithLocalCache.java: ## @@ -61,7 +61,6 @@ import org.apache.hadoop.hive.metastore.api.TableVa

Re: [PR] HIVE-26547: setting primary key constraint for DELEGATION_TOKENS tabl… [hive]

2024-02-23 Thread via GitHub
nrg4878 commented on PR #3942: URL: https://github.com/apache/hive/pull/3942#issuecomment-1961848660 re-opening the PR for review. We need to review and merge this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] HIVE-26547: setting primary key constraint for DELEGATION_TOKENS tabl… [hive]

2024-02-23 Thread via GitHub
thakkardharmik opened a new pull request, #3942: URL: https://github.com/apache/hive/pull/3942 …e in oracle ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

Re: [PR] HIVE-27848 - TestCrudCompactorOnTez.secondCompactionShouldBeRefusedBe… [hive]

2024-02-23 Thread via GitHub
sonarcloud[bot] commented on PR #4859: URL: https://github.com/apache/hive/pull/4859#issuecomment-1961739088 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27848 - TestCrudCompactorOnTez.secondCompactionShouldBeRefusedBe… [hive]

2024-02-23 Thread via GitHub
tarak271 commented on code in PR #4859: URL: https://github.com/apache/hive/pull/4859#discussion_r1500923581 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java: ## @@ -50,59 +49,53 @@ import java.io.IOException; import java.security.PrivilegedException

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500852533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500818017 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit readFileForCom

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500895017 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -254,18 +286,26 @@ private void generateActualTasks(HiveConf conf, List> resTsks

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500872749 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500889203 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List getPartitionsByExpr(org.apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500871964 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500868679 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500884580 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -147,18 +171,23 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500880192 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() { public void setLbCtx(

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500878277 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500872749 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500871964 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500868679 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500862337 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader getRecord

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500857349 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader getRecord

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500854772 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int numSplits,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500852533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500851164 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500851164 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500848177 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] HIVE-27405 - Throw out the detail error Invalid partition name to the… [hive]

2024-02-23 Thread via GitHub
zhangbutao merged PR #5087: URL: https://github.com/apache/hive/pull/5087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500832533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List getPartitionsByExpr(org.apache

Re: [PR] HIVE-28021: Iceberg: Attempting to create a table with a percent symbol fails [hive]

2024-02-23 Thread via GitHub
zhangbutao merged PR #5024: URL: https://github.com/apache/hive/pull/5024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500832533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List getPartitionsByExpr(org.apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500832533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List getPartitionsByExpr(org.apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500818017 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit readFileForCom

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500818017 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit readFileForCom

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500813178 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit readFileForCom

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500803369 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void commitTask(TaskAttemptContext or

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500801678 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void commitTask(TaskAttemptContext or

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500798174 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader> getRecordReader(InputSplit

Re: [PR] HIVE-28021: escape percent symbol [hive]

2024-02-23 Thread via GitHub
tthorpeIBM commented on PR #5024: URL: https://github.com/apache/hive/pull/5024#issuecomment-1961307833 @zhangbutao are you able to merge the PR? I don't have write access. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

2024-02-23 Thread via GitHub
kasakrisz commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500474777 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void commitTask(TaskAttemptContext or

Re: [PR] HIVE-27556: Add Unit Test for KafkaStorageHandlerInfo [hive]

2024-02-23 Thread via GitHub
abstractdog merged PR #4540: URL: https://github.com/apache/hive/pull/4540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-02-23 Thread via GitHub
sonarcloud[bot] commented on PR #4959: URL: https://github.com/apache/hive/pull/4959#issuecomment-1961021208 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27692: Explore removing the always task from the embedded Metastore [hive]

2024-02-23 Thread via GitHub
dengzhhu653 merged PR #4782: URL: https://github.com/apache/hive/pull/4782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach