sonarcloud[bot] commented on PR #5139:
URL: https://github.com/apache/hive/pull/5139#issuecomment-2046562571
## [ t
abstractdog commented on PR #5139:
URL: https://github.com/apache/hive/pull/5139#issuecomment-2046471446
LGTM, we can merge until I finalize
[HIVE-28135](https://issues.apache.org/jira/browse/HIVE-28135)
--
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on PR #5189:
URL: https://github.com/apache/hive/pull/5189#issuecomment-2046470263
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
abstractdog merged PR #5039:
URL: https://github.com/apache/hive/pull/5039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #5188:
URL: https://github.com/apache/hive/pull/5188#issuecomment-2046340287
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
okumin opened a new pull request, #5189:
URL: https://github.com/apache/hive/pull/5189
### What changes were proposed in this pull request?
Ignore `hive.cbo.fallback.strategy` if EXCEPT or INTERSECT are used.
I have considered some alternatives.
- Always show the error
sonarcloud[bot] commented on PR #5187:
URL: https://github.com/apache/hive/pull/5187#issuecomment-2046290988
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
simhadri-g opened a new pull request, #5188:
URL: https://github.com/apache/hive/pull/5188
…n IOContext
### What changes were proposed in this pull request?
Make PositionDeleteInfo in IOContext Thread Safe
### Why are the changes needed?
Assume:
Query
slfan1989 opened a new pull request, #5187:
URL: https://github.com/apache/hive/pull/5187
### What changes were proposed in this pull request?
JIRA: HIVE-28191. Upgrade Hadoop Version to 3.4.0.
The 3.4.0 version of Hadoop has been released, and we aim for this version
github-actions[bot] closed pull request #4987: Branch 3 ref meta tool
URL: https://github.com/apache/hive/pull/4987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #5052:
URL: https://github.com/apache/hive/pull/5052#issuecomment-2046236201
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the
sonarcloud[bot] commented on PR #5123:
URL: https://github.com/apache/hive/pull/5123#issuecomment-2046094834
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2045920653
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
aturoczy commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558094523
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse
InvisibleProgrammer commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2045795285
@kasakrisz , what do you think, what should be the expected behaviour when
the heartbeat fails:
- should it cancel the query and Hive give an exception, so that the user
InvisibleProgrammer opened a new pull request, #5186:
URL: https://github.com/apache/hive/pull/5186
It fails with the following error:
```
org.springframework.dao.InvalidDataAccessApiUsageException: SQL [UPDATE
"MATERIALIZATION_REBUILD_LOCKS" SET "MRL_LAST_HEARTBEAT" =
sonarcloud[bot] commented on PR #5139:
URL: https://github.com/apache/hive/pull/5139#issuecomment-2045779322
## [ {
return (String)value;
}
else if (type
kasakrisz merged PR #5136:
URL: https://github.com/apache/hive/pull/5136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
deniskuzZ commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557552575
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
deniskuzZ commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557544737
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
deniskuzZ commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557548639
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
tanishq-chugh commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557548733
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
deniskuzZ commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557544737
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
deniskuzZ commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557540941
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
tanishq-chugh commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557532389
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
tanishq-chugh commented on PR #5165:
URL: https://github.com/apache/hive/pull/5165#issuecomment-2045000246
@deniskuzZ Yes, you can access the results using this url --
http://ci.hive.apache.org/job/hive-flaky-check/829/
--
This is an automated message from the Apache Git Service.
To
deniskuzZ commented on PR #5165:
URL: https://github.com/apache/hive/pull/5165#issuecomment-2044910592
@tanishq-chugh , have you tried it with
[hive-flaky-check](http://ci.hive.apache.org/job/hive-flaky-check/) runner?
--
This is an automated message from the Apache Git Service.
To
deniskuzZ commented on code in PR #5164:
URL: https://github.com/apache/hive/pull/5164#discussion_r1557501992
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java:
##
@@ -85,7 +86,24 @@ public int execute() {
} else {
throw new
deniskuzZ commented on code in PR #5105:
URL: https://github.com/apache/hive/pull/5105#discussion_r1557496976
##
packaging/src/docker/README.md:
##
@@ -5,8 +5,39 @@ Run Apache Hive inside docker container in pseudo-distributed
mode, provide the
- Quick-start/Debugging/Prepare
kasakrisz commented on PR #5136:
URL: https://github.com/apache/hive/pull/5136#issuecomment-2044879633
@okumin
Good catch. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sonarcloud[bot] commented on PR #5154:
URL: https://github.com/apache/hive/pull/5154#issuecomment-2044868027
## [?
--
This is an automated message from the Apache Git Service.
To respond to
deniskuzZ merged PR #5014:
URL: https://github.com/apache/hive/pull/5014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
deniskuzZ commented on PR #5002:
URL: https://github.com/apache/hive/pull/5002#issuecomment-2044753664
@ryukobayashi, could you please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
deniskuzZ commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538
##
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##
@@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI
fromURI, Table table) t
deniskuzZ commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538
##
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##
@@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI
fromURI, Table table) t
deniskuzZ commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538
##
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##
@@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI
fromURI, Table table) t
deniskuzZ commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1557452129
##
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##
@@ -325,6 +337,8 @@ private void analyzeLoad(ASTNode ast) throws
SemanticException {
deniskuzZ commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538
##
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##
@@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI
fromURI, Table table) t
sonarcloud[bot] commented on PR #4744:
URL: https://github.com/apache/hive/pull/4744#issuecomment-2044699211
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
kasakrisz commented on code in PR #5143:
URL: https://github.com/apache/hive/pull/5143#discussion_r1557333427
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##
@@ -39,6 +44,28 @@ public List
kasakrisz commented on code in PR #5143:
URL: https://github.com/apache/hive/pull/5143#discussion_r1557323986
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##
@@ -39,6 +44,28 @@ public List
sonarcloud[bot] commented on PR #5014:
URL: https://github.com/apache/hive/pull/5014#issuecomment-2044528317
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
okumin commented on PR #5136:
URL: https://github.com/apache/hive/pull/5136#issuecomment-2044519968
@kasakrisz @deniskuzZ Maybe, this is not HIVE-27831 maybe but HIVE-28126.
You may update the commit message on merging this PR.
--
This is an automated message from the Apache Git Service.
deniskuzZ commented on code in PR #5166:
URL: https://github.com/apache/hive/pull/5166#discussion_r1557261558
##
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##
@@ -14495,6 +14495,9 @@ private void validateStorageFormat(
+ "'='"
deniskuzZ commented on code in PR #5166:
URL: https://github.com/apache/hive/pull/5166#discussion_r1557261558
##
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##
@@ -14495,6 +14495,9 @@ private void validateStorageFormat(
+ "'='"
deniskuzZ commented on code in PR #5143:
URL: https://github.com/apache/hive/pull/5143#discussion_r1557247554
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##
@@ -39,6 +44,28 @@ public List
deniskuzZ commented on code in PR #5143:
URL: https://github.com/apache/hive/pull/5143#discussion_r1557244910
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##
@@ -39,6 +44,28 @@ public List
deniskuzZ commented on code in PR #5143:
URL: https://github.com/apache/hive/pull/5143#discussion_r1557238747
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##
@@ -39,6 +44,28 @@ public List
deniskuzZ commented on code in PR #5143:
URL: https://github.com/apache/hive/pull/5143#discussion_r1557238747
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##
@@ -39,6 +44,28 @@ public List
deniskuzZ commented on PR #5129:
URL: https://github.com/apache/hive/pull/5129#issuecomment-204862
unrelated test failure, restarted the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sonarcloud[bot] commented on PR #5185:
URL: https://github.com/apache/hive/pull/5185#issuecomment-2044369321
## [