Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

sonarcloud[bot] commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2058183246 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

ryukobayashi commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2058149316 @deniskuzZ I have fixed it as per your suggestion. But, we did not integrate it with UDFLike because it would require major fixes to the logic. Please let me know if you think it

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

sonarcloud[bot] commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2057916449 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

ayushtkn commented on code in PR #5190: URL: https://github.com/apache/hive/pull/5190#discussion_r1566465250 ## parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g: ## @@ -513,6 +514,13 @@ alterStatementSuffixRenameBranch -> ^(TOK_ALTERTABLE_RENAME_BRANCH

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

ayushtkn commented on code in PR #5190: URL: https://github.com/apache/hive/pull/5190#discussion_r1566464456 ## iceberg/iceberg-handler/src/test/queries/positive/replace_iceberg_branch.q: ## @@ -0,0 +1,28 @@ +-- SORT_QUERY_RESULTS +set hive.explain.user=false; +set

[PR] [WIP] Calcite upgrade 1.33 [hive]

soumyakanti3578 opened a new pull request, #5196: URL: https://github.com/apache/hive/pull/5196 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is

Re: [PR] HIVE-28199: Fix docker issues with Hive 3.1.3 on Mac. [hive]

ryandgoldenberg commented on PR #5178: URL: https://github.com/apache/hive/pull/5178#issuecomment-2057814677 > @ryandgoldenberg Thank you for the contribution, we use jira for issues/case management: https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-JIRA,

Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]

sonarcloud[bot] commented on PR #5186: URL: https://github.com/apache/hive/pull/5186#issuecomment-2057781933 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Draft: ORC projected size fix for ACID [hive]

sonarcloud[bot] commented on PR #5195: URL: https://github.com/apache/hive/pull/5195#issuecomment-2057694125 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Draft: ORC projected size fix for ACID [hive]

deniskuzZ opened a new pull request, #5195: URL: https://github.com/apache/hive/pull/5195 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565823941 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -569,14 +575,25 @@ private void commitWrite(Table table, String

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

okumin commented on code in PR #5191: URL: https://github.com/apache/hive/pull/5191#discussion_r1565852758 ## ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java: ## @@ -1736,6 +1749,13 @@ private static boolean isWideningCast(ExprNodeGenericFuncDesc engfd) {

Re: [PR] Fix docker issues with Hive 3.1.3 on Mac. [hive]

dengzhhu653 commented on PR #5178: URL: https://github.com/apache/hive/pull/5178#issuecomment-2056917417 @ryandgoldenberg Thank you for the contribution, we use jira for issues/case management: https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-JIRA, could

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565823941 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -569,14 +575,25 @@ private void commitWrite(Table table, String

Re: [PR] Update Hive version in Docker README [hive]

sonarcloud[bot] commented on PR #5105: URL: https://github.com/apache/hive/pull/5105#issuecomment-2056888797 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Update Hive version in Docker README [hive]

dengzhhu653 commented on code in PR #5105: URL: https://github.com/apache/hive/pull/5105#discussion_r1565807011 ## packaging/src/docker/README.md: ## @@ -59,7 +60,7 @@ If the version is not provided, it will read the version from current `pom.xml`: For example, the

Re: [PR] Update Hive version in Docker README [hive]

mertyyanik commented on code in PR #5105: URL: https://github.com/apache/hive/pull/5105#discussion_r1565745559 ## packaging/src/docker/README.md: ## @@ -5,8 +5,39 @@ Run Apache Hive inside docker container in pseudo-distributed mode, provide the -

Re: [PR] Update Hive version in Docker README [hive]

mertyyanik commented on code in PR #5105: URL: https://github.com/apache/hive/pull/5105#discussion_r1565745559 ## packaging/src/docker/README.md: ## @@ -5,8 +5,39 @@ Run Apache Hive inside docker container in pseudo-distributed mode, provide the -

Re: [PR] Update Hive version in Docker README [hive]

mertyyanik commented on code in PR #5105: URL: https://github.com/apache/hive/pull/5105#discussion_r1565745559 ## packaging/src/docker/README.md: ## @@ -5,8 +5,39 @@ Run Apache Hive inside docker container in pseudo-distributed mode, provide the -

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565744058 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +52,68 @@ public boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565481530 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -569,14 +575,25 @@ private void commitWrite(Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565694331 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +52,68 @@ public boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565694331 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +52,68 @@ public boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565694331 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +52,68 @@ public boolean

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

sonarcloud[bot] commented on PR #5131: URL: https://github.com/apache/hive/pull/5131#issuecomment-2056526306 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

cxzl25 commented on PR #5141: URL: https://github.com/apache/hive/pull/5141#issuecomment-2056452806 @saihemanth-cloudera @zhangbutao Please help review again when you have time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] HIVE-28153: Flaky test TestConflictingDataFiles.testMultiFiltersUpdate [hive]

simhadri-g commented on PR #5193: URL: https://github.com/apache/hive/pull/5193#issuecomment-2056452513 Thanks @deniskuzZ and @zhangbutao for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565481530 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -569,14 +575,25 @@ private void commitWrite(Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565474973 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -569,14 +575,25 @@ private void commitWrite(Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565474973 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -569,14 +575,25 @@ private void commitWrite(Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1565469401 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -640,7 +640,13 @@ public void

Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]

zratkai commented on code in PR #5186: URL: https://github.com/apache/hive/pull/5186#discussion_r1565469449 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -705,12 +706,11 @@ public LockResponse

Re: [PR] HIVE-28133: Log the original exception in HiveIOExceptionHandlerUtil#handleRecordReaderException [hive]

deniskuzZ merged PR #5139: URL: https://github.com/apache/hive/pull/5139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

sonarcloud[bot] commented on PR #5131: URL: https://github.com/apache/hive/pull/5131#issuecomment-2055794675 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Testing [hive]

sonarcloud[bot] commented on PR #5194: URL: https://github.com/apache/hive/pull/5194#issuecomment-205349 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate