[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-10 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453110112 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ## @@ -1980,6 +1989,7 @@

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-10 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453104847 ## File path: ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java ## @@ -232,6 +235,8 @@ public void setup() throws

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-10 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453104603 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3911,20 +3962,27 @@ public boolean dropPartition(String dbName, String

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-10 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453104328 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -1459,6 +1464,22 @@ public Table getTable(final String dbName, final String

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-10 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453103330 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -1459,6 +1464,22 @@ public Table getTable(final String dbName, final String

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-10 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453103050 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3580,7 +3596,17 @@ public boolean dropPartition(String dbName, String

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-08 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451334032 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3284,6 +3299,8 @@ public Partition getPartition(Table tbl, Map partSpec,

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-07 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451058731 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3580,7 +3592,19 @@ public boolean dropPartition(String dbName, String

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

2020-07-07 Thread GitBox
kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451057776 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableOperation.java ## @@ -62,7 +62,8 @@ public int execute() throws