[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

2020-08-03 Thread GitBox
pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464483465 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

2020-08-03 Thread GitBox
pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464476338 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

2020-08-03 Thread GitBox
pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464473125 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1641,28 +1645,26 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

2020-08-03 Thread GitBox
pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464472005 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

2020-07-30 Thread GitBox
pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463249932 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1574,45 +1576,46 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

2020-07-30 Thread GitBox
pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463237211 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -680,14 +681,15 @@ public void