[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-30 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r462725998 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -312,5 +558,9 @@ private String

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-29 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r462038305 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -81,48 +92,269 @@ public HiveMe

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-22 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r458607547 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -81,48 +92,261 @@ public HiveMe

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-22 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r458606157 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ## @@ -35,6 +35,7 @@ import

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-22 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r458605769 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/ReadTableEvent.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-22 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r458605407 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/ReadTableEvent.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451290794 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451289748 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -312,5 +578,13 @@ private Strin

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451288969 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -198,6 +446,29 @@ HiveMetaStore

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451287139 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451286260 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451285302 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451284085 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ## @@ -427,7 +428,7 @@ public

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451284051 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ## @@ -416,7 +417,7 @@ public

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451283728 ## File path: ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java ## @@ -283,4 +284,50 @@ public vo

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451283245 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/filtercontext/DatabaseFilterContext.java ## @@ -0,0 +1,78 @@ +/* +

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451282859 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java ## @@ -123,13 +123,13 @@ public void te

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

2020-07-07 Thread GitBox
pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451282795 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java ## @@ -123,13 +123,13 @@ public void te