[GitHub] [hive] pvary commented on a change in pull request #2228: HIVE-25062 Iceberg: Fix date partition transform insert issue

2021-04-28 Thread GitBox
pvary commented on a change in pull request #2228: URL: https://github.com/apache/hive/pull/2228#discussion_r622249484 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java ## @@ -759,6 +763,108 @@ public

[GitHub] [hive] pvary commented on a change in pull request #2228: HIVE-25062 Iceberg: Fix date partition transform insert issue

2021-04-28 Thread GitBox
pvary commented on a change in pull request #2228: URL: https://github.com/apache/hive/pull/2228#discussion_r622242175 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java ## @@ -107,6 +110,8 @@

[GitHub] [hive] pvary commented on a change in pull request #2228: HIVE-25062 Iceberg: Fix date partition transform insert issue

2021-04-28 Thread GitBox
pvary commented on a change in pull request #2228: URL: https://github.com/apache/hive/pull/2228#discussion_r622242014 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java ## @@ -759,6 +763,108 @@ public

[GitHub] [hive] pvary commented on a change in pull request #2228: HIVE-25062 Iceberg: Fix date partition transform insert issue

2021-04-28 Thread GitBox
pvary commented on a change in pull request #2228: URL: https://github.com/apache/hive/pull/2228#discussion_r622240406 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java ## @@ -759,6 +763,108 @@ public

[GitHub] [hive] pvary commented on a change in pull request #2228: HIVE-25062 Iceberg: Fix date partition transform insert issue

2021-04-28 Thread GitBox
pvary commented on a change in pull request #2228: URL: https://github.com/apache/hive/pull/2228#discussion_r67816 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java ## @@ -107,6 +110,8 @@

[GitHub] [hive] pvary commented on a change in pull request #2228: HIVE-25062 Iceberg: Fix date partition transform insert issue

2021-04-28 Thread GitBox
pvary commented on a change in pull request #2228: URL: https://github.com/apache/hive/pull/2228#discussion_r67503 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java ## @@ -759,6 +763,108 @@ public