Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-26 Thread via GitHub
InvisibleProgrammer commented on PR #5118: URL: https://github.com/apache/hive/pull/5118#issuecomment-2019872713 Short version: LGTM. Long version: I checked it out with a PR that uses postgresql driver as a default one to check what happens if we want to run all the qtestst with

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516381314 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE", "MYSQL",

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516378255 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE", "MYSQL",

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
InvisibleProgrammer commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516214769 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE",

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
InvisibleProgrammer commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516203028 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE",

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-06 Thread via GitHub
sonarcloud[bot] commented on PR #5118: URL: https://github.com/apache/hive/pull/5118#issuecomment-1981385891 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-05 Thread via GitHub
sonarcloud[bot] commented on PR #5118: URL: https://github.com/apache/hive/pull/5118#issuecomment-1978951483 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-05 Thread via GitHub
zratkai opened a new pull request, #5118: URL: https://github.com/apache/hive/pull/5118 Change-Id: I2c37973af59f69d17de733d69f184fe83bcc3091 ### What changes were proposed in this pull request? Changes to be able to run multiple Qtests with Postgre. ### Why are the