[GitHub] [hive] dlavati opened a new pull request #1207: HIVE-23483: Remove DynamicSerDe

dlavati opened a new pull request #1207: URL: https://github.com/apache/hive/pull/1207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] dgzdot opened a new pull request #1206: HIVE-23802:“merge files” job was submited to default queue when set h…

dgzdot opened a new pull request #1206: URL: https://github.com/apache/hive/pull/1206 …ive.merge.tezfiles to true ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the

[GitHub] [hive] kgyrtkirk commented on pull request #1196: HIVE-23791: Optimize ACID stats generation

kgyrtkirk commented on pull request #1196: URL: https://github.com/apache/hive/pull/1196#issuecomment-654113119 http://ci.hive.apache.org/job/hive-precommit/job/PR-1196/2/ is valid for this pr; branch indexing have started ~80 ptest runs which I had to cancel manually...

[GitHub] [hive] nareshpr opened a new pull request #1214: HIVE-23811: deleteReader SARG rowId is not getting validated properly

nareshpr opened a new pull request #1214: URL: https://github.com/apache/hive/pull/1214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] jcamachor commented on a change in pull request #1212: HIVE-23807 Wrong results with vectorization enabled

jcamachor commented on a change in pull request #1212: URL: https://github.com/apache/hive/pull/1212#discussion_r450617751 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java ## @@ -116,14 +118,16 @@ public void

[GitHub] [hive] StefanXiepj closed pull request #1208: Hive 22412: StatsUtils throw NPE when explain

StefanXiepj closed pull request #1208: URL: https://github.com/apache/hive/pull/1208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] StefanXiepj opened a new pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

StefanXiepj opened a new pull request #1209: URL: https://github.com/apache/hive/pull/1209 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] kgyrtkirk opened a new pull request #1210: HIVE-22301: Hive lineage is not generated for insert overwrite queries on partitioned tables

kgyrtkirk opened a new pull request #1210: URL: https://github.com/apache/hive/pull/1210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] belugabehr closed pull request #1153: HIVE-23731: Review of AvroInstance Cache

belugabehr closed pull request #1153: URL: https://github.com/apache/hive/pull/1153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] belugabehr commented on a change in pull request #1211: HIVE-23790: The error message length of 2000 is exceeded for scheduled query

belugabehr commented on a change in pull request #1211: URL: https://github.com/apache/hive/pull/1211#discussion_r450245316 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestMetastoreScheduledQueries.java ## @@

[GitHub] [hive] belugabehr commented on pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

belugabehr commented on pull request #1209: URL: https://github.com/apache/hive/pull/1209#issuecomment-654250436 Thanks for the contribution. I need to look at it more, but if 'null' is not a valid option to pass into the constructors, then it should be prohibited:

[GitHub] [hive] kgyrtkirk commented on pull request #1211: HIVE-23790: The error message length of 2000 is exceeded for scheduled query

kgyrtkirk commented on pull request #1211: URL: https://github.com/apache/hive/pull/1211#issuecomment-654263274 I didn't wanted to get into trouble because of utf stuff; so I clip the message at 1K ; the purpose of this error message field is to given an idea what was the problem - and

[GitHub] [hive] kgyrtkirk commented on pull request #1210: HIVE-22301: Hive lineage is not generated for insert overwrite queries on partitioned tables

kgyrtkirk commented on pull request #1210: URL: https://github.com/apache/hive/pull/1210#issuecomment-654235092 I feel that there is a strong correlation between something being `!complete` and `dummy_partition` This is an

[GitHub] [hive] belugabehr closed pull request #1203: HIVE-22674: Replace Base64 in serde Package

belugabehr closed pull request #1203: URL: https://github.com/apache/hive/pull/1203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] jfsii commented on pull request #1119: HIVE-23699: Cleanup HIVEQUERYRESULTFILEFORMAT handling

jfsii commented on pull request #1119: URL: https://github.com/apache/hive/pull/1119#issuecomment-654280518 Rebased, so it should kick off tests again This is an automated message from the Apache Git Service. To respond to

[GitHub] [hive] belugabehr closed pull request #1088: HIVE-23673: Maven Standard Directories for accumulo-handler

belugabehr closed pull request #1088: URL: https://github.com/apache/hive/pull/1088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kgyrtkirk opened a new pull request #1211: HIVE-23790: The error message length of 2000 is exceeded for scheduled query

kgyrtkirk opened a new pull request #1211: URL: https://github.com/apache/hive/pull/1211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] belugabehr commented on a change in pull request #1201: HIVE-23797: Throw exception when no metastore found in zookeeper

belugabehr commented on a change in pull request #1201: URL: https://github.com/apache/hive/pull/1201#discussion_r450251647 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ## @@ -327,6 +327,13 @@

[GitHub] [hive] pvary merged pull request #1204: HIVE-23799: Fix AcidUtils.parseBaseOrDeltaBucketFilename handling of data loaded by LOAD DATA

pvary merged pull request #1204: URL: https://github.com/apache/hive/pull/1204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1201: HIVE-23797: Throw exception when no metastore found in zookeeper

dengzhhu653 commented on a change in pull request #1201: URL: https://github.com/apache/hive/pull/1201#discussion_r450287586 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ## @@ -327,6 +327,13 @@

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1161: HIVE-23638: Spotbugs issues in hive-common

kgyrtkirk commented on a change in pull request #1161: URL: https://github.com/apache/hive/pull/1161#discussion_r450299299 ## File path: common/src/java/org/apache/hadoop/hive/conf/Validator.java ## @@ -357,14 +357,15 @@ public String validate(String value) { final Path

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450317451 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java ## @@ -74,21 +76,21 @@ @Before public void setUp() throws

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450302033 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -2392,33 +2392,29 @@ public static TableSnapshot

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450326885 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ## @@ -8322,6 +8322,22 @@ public

[GitHub] [hive] ramesh0201 commented on a change in pull request #1177: HIVE-23665 Rewrite last_value to first_value to enable streaming results

ramesh0201 commented on a change in pull request #1177: URL: https://github.com/apache/hive/pull/1177#discussion_r450347761 ## File path: ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out ## @@ -314,46 +386,46 @@ POSTHOOK: type: QUERY POSTHOOK: Input:

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450361883 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450315397 ## File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java ## @@ -2209,20 +2209,7 @@ public void testAcidOrcWritePreservesFieldNames()

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450334396 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java ## @@ -111,24 +120,24 @@

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450360016 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java ## @@ -429,6 +451,75 @@ void

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450362382 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1201: HIVE-23797: Throw exception when no metastore found in zookeeper

dengzhhu653 commented on a change in pull request #1201: URL: https://github.com/apache/hive/pull/1201#discussion_r450288096 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ## @@ -327,6 +327,13 @@

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450301348 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -2392,33 +2392,29 @@ public static TableSnapshot

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450360969 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450318861 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -2392,33 +2392,29 @@ public static TableSnapshot

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450318970 ## File path: ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java ## @@ -162,9 +163,23 @@ protected String getWarehouseDir() { * takes

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450338348 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java ## @@ -429,6 +451,75 @@ void

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450361266 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450361792 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] StefanXiepj opened a new pull request #1208: Hive 22412: StatsUtils throw NPE when explain

StefanXiepj opened a new pull request #1208: URL: https://github.com/apache/hive/pull/1208 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] pvary merged pull request #1196: HIVE-23791: Optimize ACID stats generation

pvary merged pull request #1196: URL: https://github.com/apache/hive/pull/1196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] xiaomengzhang commented on pull request #1213: HIVE-23765: Use ORC file format by default when creating transactiona…

xiaomengzhang commented on pull request #1213: URL: https://github.com/apache/hive/pull/1213#issuecomment-654462812 @nrg4878 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hive] xiaomengzhang opened a new pull request #1213: HIVE-23765: Use ORC file format by default when creating transactiona…

xiaomengzhang opened a new pull request #1213: URL: https://github.com/apache/hive/pull/1213 …l table When table has property that transactional is 'true' and transactional_properties is not 'insert_only', make fileformat ORC. ## NOTICE Please create an issue in ASF

[GitHub] [hive] vineetgarg02 opened a new pull request #1212: HIVE-23807 Wrong results with vectorization enabled

vineetgarg02 opened a new pull request #1212: URL: https://github.com/apache/hive/pull/1212 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] StefanXiepj commented on pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

StefanXiepj commented on pull request #1209: URL: https://github.com/apache/hive/pull/1209#issuecomment-654557578 > Thanks for the contribution. > > I need to look at it more, but if 'null' is not a valid option to pass into the constructors, then it should be prohibited:

[GitHub] [hive] adesh-rao commented on a change in pull request #1109: HIVE-22015: Add table constraints in CachedStore

adesh-rao commented on a change in pull request #1109: URL: https://github.com/apache/hive/pull/1109#discussion_r450598395 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -543,10 +557,30 @@ static

[GitHub] [hive] adesh-rao commented on a change in pull request #1109: HIVE-22015: Add table constraints in CachedStore

adesh-rao commented on a change in pull request #1109: URL: https://github.com/apache/hive/pull/1109#discussion_r450599566 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -2497,26 +2610,87 @@ long